-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution][Detections] Adds Nested CTI row renderer #96275
Commits on Apr 13, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 20dd329 - Browse repository at this point
Copy the full SHA 20dd329View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a1a613 - Browse repository at this point
Copy the full SHA 6a1a613View commit details -
Test and implement CTI row renderer
The display details are not yet implemented, but those will be fleshed out in the ThreatMatchRow component.
Configuration menu - View commit details
-
Copy full SHA for 9b12c87 - Browse repository at this point
Copy the full SHA 9b12c87View commit details -
Pass full fields data to our row renderers
This data is not used by any existing row renderers and so this commit is mostly just plumbing that data through. This is necessary, however, for our new threat match row renderer as it requires nested fields, which cannot be retrieved through the mechanism that retrieves the existing row renderer data. However, these nested fields are available, if requested, through this other data structure, hence this plumbing. For now to minimize changes I'm marking this as an optional field; however in reality a value will always be present.
Configuration menu - View commit details
-
Copy full SHA for e373e78 - Browse repository at this point
Copy the full SHA e373e78View commit details -
Rewrite existing row renderer in terms of flattened data
Updates logic, tests and mocks accordingly.
Configuration menu - View commit details
-
Copy full SHA for f42ba60 - Browse repository at this point
Copy the full SHA f42ba60View commit details -
Moving logic into discrete files
* helpers * explicit fields file, which will hopefully be part of the renderer API at some point * parent component to split data into "rows" as defined by our renderer * row component for stateless presentation of a single match
Configuration menu - View commit details
-
Copy full SHA for 10a53f8 - Browse repository at this point
Copy the full SHA 10a53f8View commit details -
Register threat match row rendere
Adds tentative copy, example row, and accompanying mock data.
Configuration menu - View commit details
-
Copy full SHA for 9d7afd0 - Browse repository at this point
Copy the full SHA 9d7afd0View commit details -
WIP: Rendering draggable fields but hit the data loss issue with nest…
…ed fields being flattened
Configuration menu - View commit details
-
Copy full SHA for adf7067 - Browse repository at this point
Copy the full SHA adf7067View commit details -
WIP: implementing row renderer against new data format
I haven't yet deleted the old (new?) unused path yet. Cleanup to come.
Configuration menu - View commit details
-
Copy full SHA for 6fc1d90 - Browse repository at this point
Copy the full SHA 6fc1d90View commit details -
* Rewrites isInstance logic for new data as helper, hasThreatMatchValue * Updating types and tests * Adds to the previously empty ThreatEcs
Configuration menu - View commit details
-
Copy full SHA for c2eb905 - Browse repository at this point
Copy the full SHA c2eb905View commit details -
Revert "Pass full fields data to our row renderers"
This reverts commit 19c93ee. We ended up extending the existing data (albeit from the fields response!).
Configuration menu - View commit details
-
Copy full SHA for b20b71b - Browse repository at this point
Copy the full SHA b20b71bView commit details -
* adds contextId and eventId to pass to draggable * We don't have a order-independent key for each individual ThreatMatchRow, due to matched.id not being mapped/returned in the fields response * Fixes up a few things related to using the new data format
Configuration menu - View commit details
-
Copy full SHA for 39f1880 - Browse repository at this point
Copy the full SHA 39f1880View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3477d27 - Browse repository at this point
Copy the full SHA 3477d27View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a6f6fd - Browse repository at this point
Copy the full SHA 0a6f6fdView commit details -
Move CTI field constants to common folder
In order to use these in both the row renderer and the server request, we need to move them to common/
Configuration menu - View commit details
-
Copy full SHA for f6f887c - Browse repository at this point
Copy the full SHA f6f887cView commit details -
Remove redundant CTI fields from client request
These are currently hardcoded on the backend of the events/all query (via TIMELINE_EVENTS_FIELDS); declaring them on both ends is arguably confusing, and we're going with YAGNI for now.
Configuration menu - View commit details
-
Copy full SHA for 72b5b3f - Browse repository at this point
Copy the full SHA 72b5b3fView commit details -
This was causing type errors as this enum exists both here and in common/, and I had only updated one of them.
Configuration menu - View commit details
-
Copy full SHA for f95f8e3 - Browse repository at this point
Copy the full SHA f95f8e3View commit details -
One is still failing due to an outdated test subject, but I expect this to change after an upcoming meeting so leaving it for now.
Configuration menu - View commit details
-
Copy full SHA for 838e548 - Browse repository at this point
Copy the full SHA 838e548View commit details
Commits on Apr 14, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 73a3d1d - Browse repository at this point
Copy the full SHA 73a3d1dView commit details -
Split ThreatMatchRow into subcomponents
One for displaying match details, and another for indicator details The indicator details will be sparse, so there's going to be some conditional rendering in there.
Configuration menu - View commit details
-
Copy full SHA for 90f6004 - Browse repository at this point
Copy the full SHA 90f6004View commit details -
Make CTI row renderer look nice
* Adds translations for copy * Fixes most of our layout woes with more flexbox! * Conditional rendering of indicator details based on data * tests
Configuration menu - View commit details
-
Copy full SHA for d625b2c - Browse repository at this point
Copy the full SHA d625b2cView commit details
Commits on Apr 15, 2021
-
Make indicator reference field an external link
Leverages the existing FormattedFieldValue component, with one minor tweak to add this field to the URL allowlist.
Configuration menu - View commit details
-
Copy full SHA for d14f795 - Browse repository at this point
Copy the full SHA d14f795View commit details -
Back to consistent horizontal spacing, here
The draggable badges are a little odd in that their full box isn't indicated until hover, making the visual weight a little off.
Configuration menu - View commit details
-
Copy full SHA for 5fbcf64 - Browse repository at this point
Copy the full SHA 5fbcf64View commit details -
Configuration menu - View commit details
-
Copy full SHA for d7cce75 - Browse repository at this point
Copy the full SHA d7cce75View commit details -
Fix tests broken due to addition of a new row renderer
These tests are all implicitly testing the list of row renderers.
Configuration menu - View commit details
-
Copy full SHA for 5a04c28 - Browse repository at this point
Copy the full SHA 5a04c28View commit details -
At certain container widths, a half-width hr is not sufficient.
Configuration menu - View commit details
-
Copy full SHA for d8bf839 - Browse repository at this point
Copy the full SHA d8bf839View commit details -
Obviates the need for the accompanying comments.
Configuration menu - View commit details
-
Copy full SHA for 2f7433f - Browse repository at this point
Copy the full SHA 2f7433fView commit details -
Configuration menu - View commit details
-
Copy full SHA for d49d692 - Browse repository at this point
Copy the full SHA d49d692View commit details -
Configuration menu - View commit details
-
Copy full SHA for 542052b - Browse repository at this point
Copy the full SHA 542052bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9295afc - Browse repository at this point
Copy the full SHA 9295afcView commit details -
Ensure contextId is unique for each CTI subrow
We need to add the row index to our contextId to ensure that our draggables work correctly for multiple rows, since each row will necessarily have the same eventId and timelineId.
Configuration menu - View commit details
-
Copy full SHA for b115dfe - Browse repository at this point
Copy the full SHA b115dfeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8f667c7 - Browse repository at this point
Copy the full SHA 8f667c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 37d737b - Browse repository at this point
Copy the full SHA 37d737bView commit details