[TSVB] Fix annotation line doesn't work if no index pattern is applied #96646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukeelmers
added
Team:Visualizations
|
@alexwizp can you review this first? |
alexwizp
reviewed
Apr 12, 2021
| @@ -24,7 +24,7 @@ export function dateHistogram( | |||
| ) { | |||
| return (next) => async (doc) => { | |||
| const barTargetUiSettings = await uiSettings.get(UI_SETTINGS.HISTOGRAM_BAR_TARGET); | |||
| const timeField = annotation.time_field; | |||
| const timeField = annotation.time_field || indexPattern?.timeFieldName || ''; | |||
There was a problem hiding this comment.
We merged #95772. This PR should be updated and retested. At least indexPattern -> seriesIndex.indexPattern
There was a problem hiding this comment.
Updated and retested
…otations # Conflicts: # src/plugins/vis_type_timeseries/server/lib/vis_data/request_processors/annotations/date_histogram.js # src/plugins/vis_type_timeseries/server/lib/vis_data/request_processors/annotations/query.js # src/plugins/vis_type_timeseries/server/lib/vis_data/request_processors/annotations/top_hits.js
alexwizp
approved these changes
Apr 13, 2021
|
@elasticmachine merge upstream |
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
stratoula
approved these changes
Apr 13, 2021
|
Jenkins test this |
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: cc @dmitriynj |
alexwizp
pushed a commit
to alexwizp/kibana
that referenced
this pull request
Apr 13, 2021
elastic#96646) * [TSVB] fix annotation line doesnt work if no index pattern is applied * [TSVB] remove series from annotations, remove timeField placeholder Co-authored-by: Kibana Machine <[email protected]>
alexwizp
added a commit
that referenced
this pull request
Apr 13, 2021
#96646) (#96965) * [TSVB] fix annotation line doesnt work if no index pattern is applied * [TSVB] remove series from annotations, remove timeField placeholder Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Dmitry Tomashevich <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #96277
Summary
Steps to reproduce:
Expected behavior:
After changes: