[Remote Clusters] Added a11y tests and fixed violations #96989

yuliacech · 2021-04-13T15:38:28Z

Summary

This PR adds functional a11y tests for Remote Clusters plugin and fixes discovered a11y violations.
Tested views:

Empty list with an empty prompt
Add remote cluster form with a request flyout
For a sniff and a proxy mode cluster
- List view
- Details flyout
- Edit a cluster with a request flyout
- Delete modal

Checklist

Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)

…ations

elasticmachine · 2021-04-13T15:39:17Z

Pinging @elastic/kibana-accessibility (Project:Accessibility)

elasticmachine · 2021-04-13T15:39:17Z

Pinging @elastic/es-ui (Team:Elasticsearch UI)

myasonik

🚀 Awesome increase in test coverage!

yuliacech · 2021-04-14T12:01:43Z

@elasticmachine merge upstream

sebelga

Thanks for adding these a11y tests @yuliacech ! LGTM! 👍

sebelga · 2021-04-15T09:37:04Z

x-pack/test/accessibility/apps/remote_clusters.ts

+});
+
+const getPayloadClusterProxyMode = (name: string): Payload => {
+  const payload = getEmptyPayload() as Payload;


nit: you could cast it only once on L38 so you don't have to cast it each time you consume it

yuliacech · 2021-04-15T11:04:27Z

@elasticmachine merge upstream

yuliacech · 2021-04-19T13:15:24Z

@elasticmachine merge upstream

kibanamachine · 2021-04-19T15:31:13Z

💛 Build succeeded, but was flaky

continuous-integration/kibana-ci/pull-request
Commit: 46ec5ec
Storybooks Preview
Documentation Changes
Flaky suites:
- xpack-kibana-ciGroup7

Test Failures

Kibana Pipeline / general / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/dashboard/sync_colors·ts.dashboard sync colors should sync colors on dashboard by default

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 2 times on tracked branches: https://github.com/elastic/kibana/issues/97403

[00:00:00]       │
[00:00:00]         └-: dashboard
[00:00:00]           └-> "before all" hook in "dashboard"
[00:19:04]           └-: sync colors
[00:19:04]             └-> "before all" hook for "should sync colors on dashboard by default"
[00:19:04]             └-> "before all" hook for "should sync colors on dashboard by default"
[00:19:04]               │ info [logstash_functional] Loading "mappings.json"
[00:19:04]               │ info [logstash_functional] Loading "data.json.gz"
[00:19:04]               │ info [logstash_functional] Skipped restore for existing index "logstash-2015.09.22"
[00:19:04]               │ info [logstash_functional] Skipped restore for existing index "logstash-2015.09.20"
[00:19:04]               │ info [logstash_functional] Skipped restore for existing index "logstash-2015.09.21"
[00:19:05]               │ info [lens/basic] Loading "mappings.json"
[00:19:05]               │ info [lens/basic] Loading "data.json"
[00:19:05]               │ info [lens/basic] Loading "data.json.gz"
[00:19:05]               │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-centos-tests-xxl-1618838178515922555] [.kibana_8.0.0_001/_fLotdmbQ5arA9yNuD7FAg] deleting index
[00:19:05]               │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-centos-tests-xxl-1618838178515922555] [.kibana_task_manager_8.0.0_001/89E4DzWsSdaPLV5_dnByew] deleting index
[00:19:05]               │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-centos-tests-xxl-1618838178515922555] [.kibana_pre6.5.0_001/WjFMuH_9TLWZ9KGODnHWaQ] deleting index
[00:19:05]               │ info [lens/basic] Deleted existing index ".kibana_8.0.0_001"
[00:19:05]               │ info [lens/basic] Deleted existing index ".kibana_task_manager_8.0.0_001"
[00:19:05]               │ info [lens/basic] Deleted existing index ".kibana_pre6.5.0_001"
[00:19:05]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xxl-1618838178515922555] [.kibana_1] creating index, cause [api], templates [], shards [1]/[0]
[00:19:05]               │ info [lens/basic] Created index ".kibana_1"
[00:19:05]               │ debg [lens/basic] ".kibana_1" settings {"index":{"auto_expand_replicas":"0-1","number_of_replicas":"0","number_of_shards":"1"}}
[00:19:05]               │ info [lens/basic] Indexed 24 docs into ".kibana_1"
[00:19:05]               │ debg Migrating saved objects
[00:19:05]               │ proc [kibana]   log   [14:17:44.150] [info][savedobjects-service] [.kibana_task_manager] INIT -> CREATE_NEW_TARGET. took: 6ms.
[00:19:05]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xxl-1618838178515922555] [.kibana_task_manager_8.0.0_001] creating index, cause [api], templates [], shards [1]/[1]
[00:19:05]               │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-centos-tests-xxl-1618838178515922555] updating number_of_replicas to [0] for indices [.kibana_task_manager_8.0.0_001]
[00:19:05]               │ proc [kibana]   log   [14:17:44.161] [info][savedobjects-service] [.kibana] INIT -> WAIT_FOR_YELLOW_SOURCE. took: 20ms.
[00:19:05]               │ proc [kibana]   log   [14:17:44.170] [info][savedobjects-service] [.kibana] WAIT_FOR_YELLOW_SOURCE -> SET_SOURCE_WRITE_BLOCK. took: 9ms.
[00:19:05]               │ info [o.e.c.m.MetadataIndexStateService] [kibana-ci-immutable-centos-tests-xxl-1618838178515922555] adding block write to indices [[.kibana_1/uInAadHmQVyg5h_RHWeXbg]]
[00:19:06]               │ info [o.e.c.m.MetadataIndexStateService] [kibana-ci-immutable-centos-tests-xxl-1618838178515922555] completed adding block write to indices [.kibana_1]
[00:19:06]               │ proc [kibana]   log   [14:17:44.223] [info][savedobjects-service] [.kibana_task_manager] CREATE_NEW_TARGET -> MARK_VERSION_INDEX_READY. took: 73ms.
[00:19:06]               │ proc [kibana]   log   [14:17:44.239] [info][savedobjects-service] [.kibana] SET_SOURCE_WRITE_BLOCK -> CREATE_REINDEX_TEMP. took: 69ms.
[00:19:06]               │ proc [kibana]   log   [14:17:44.249] [info][savedobjects-service] [.kibana_task_manager] MARK_VERSION_INDEX_READY -> DONE. took: 26ms.
[00:19:06]               │ proc [kibana]   log   [14:17:44.250] [info][savedobjects-service] [.kibana_task_manager] Migration completed after 106ms
[00:19:06]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xxl-1618838178515922555] [.kibana_8.0.0_reindex_temp] creating index, cause [api], templates [], shards [1]/[1]
[00:19:06]               │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-centos-tests-xxl-1618838178515922555] updating number_of_replicas to [0] for indices [.kibana_8.0.0_reindex_temp]
[00:19:06]               │ proc [kibana]   log   [14:17:44.307] [info][savedobjects-service] [.kibana] CREATE_REINDEX_TEMP -> REINDEX_SOURCE_TO_TEMP. took: 68ms.
[00:19:06]               │ proc [kibana]   log   [14:17:44.315] [info][savedobjects-service] [.kibana] REINDEX_SOURCE_TO_TEMP -> REINDEX_SOURCE_TO_TEMP_WAIT_FOR_TASK. took: 8ms.
[00:19:06]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-centos-tests-xxl-1618838178515922555] [.kibana_8.0.0_reindex_temp/A_qTOZFgR8WkVYjbJKTMMA] update_mapping [_doc]
[00:19:06]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-centos-tests-xxl-1618838178515922555] [.kibana_8.0.0_reindex_temp/A_qTOZFgR8WkVYjbJKTMMA] update_mapping [_doc]
[00:19:06]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-centos-tests-xxl-1618838178515922555] [.kibana_8.0.0_reindex_temp/A_qTOZFgR8WkVYjbJKTMMA] update_mapping [_doc]
[00:19:06]               │ info [o.e.t.LoggingTaskListener] [kibana-ci-immutable-centos-tests-xxl-1618838178515922555] 30581 finished with response BulkByScrollResponse[took=76.6ms,timed_out=false,sliceId=null,updated=0,created=12,deleted=0,batches=1,versionConflicts=0,noops=0,retries=0,throttledUntil=0s,bulk_failures=[],search_failures=[]]
[00:19:06]               │ proc [kibana]   log   [14:17:44.425] [info][savedobjects-service] [.kibana] REINDEX_SOURCE_TO_TEMP_WAIT_FOR_TASK -> SET_TEMP_WRITE_BLOCK. took: 110ms.
[00:19:06]               │ info [o.e.c.m.MetadataIndexStateService] [kibana-ci-immutable-centos-tests-xxl-1618838178515922555] adding block write to indices [[.kibana_8.0.0_reindex_temp/A_qTOZFgR8WkVYjbJKTMMA]]
[00:19:06]               │ info [o.e.c.m.MetadataIndexStateService] [kibana-ci-immutable-centos-tests-xxl-1618838178515922555] completed adding block write to indices [.kibana_8.0.0_reindex_temp]
[00:19:06]               │ proc [kibana]   log   [14:17:44.463] [info][savedobjects-service] [.kibana] SET_TEMP_WRITE_BLOCK -> CLONE_TEMP_TO_TARGET. took: 38ms.
[00:19:06]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xxl-1618838178515922555] applying create index request using existing index [.kibana_8.0.0_reindex_temp] metadata
[00:19:06]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xxl-1618838178515922555] [.kibana_8.0.0_001] creating index, cause [clone_index], templates [], shards [1]/[1]
[00:19:06]               │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-centos-tests-xxl-1618838178515922555] updating number_of_replicas to [0] for indices [.kibana_8.0.0_001]
[00:19:06]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-centos-tests-xxl-1618838178515922555] [.kibana_8.0.0_001/26sjNzJ3R_SWw3fmzmtJVA] create_mapping
[00:19:06]               │ proc [kibana]   log   [14:17:44.562] [info][savedobjects-service] [.kibana] CLONE_TEMP_TO_TARGET -> OUTDATED_DOCUMENTS_SEARCH. took: 99ms.
[00:19:06]               │ proc [kibana]   log   [14:17:44.578] [info][savedobjects-service] [.kibana] OUTDATED_DOCUMENTS_SEARCH -> OUTDATED_DOCUMENTS_TRANSFORM. took: 16ms.
[00:19:06]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-centos-tests-xxl-1618838178515922555] [.kibana_8.0.0_001/26sjNzJ3R_SWw3fmzmtJVA] update_mapping [_doc]
[00:19:06]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-centos-tests-xxl-1618838178515922555] [.kibana_8.0.0_001/26sjNzJ3R_SWw3fmzmtJVA] update_mapping [_doc]
[00:19:07]               │ proc [kibana]   log   [14:17:45.512] [info][savedobjects-service] [.kibana] OUTDATED_DOCUMENTS_TRANSFORM -> OUTDATED_DOCUMENTS_SEARCH. took: 934ms.
[00:19:07]               │ proc [kibana]   log   [14:17:45.524] [info][savedobjects-service] [.kibana] OUTDATED_DOCUMENTS_SEARCH -> UPDATE_TARGET_MAPPINGS. took: 12ms.
[00:19:07]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-centos-tests-xxl-1618838178515922555] [.kibana_8.0.0_001/26sjNzJ3R_SWw3fmzmtJVA] update_mapping [_doc]
[00:19:07]               │ proc [kibana]   log   [14:17:45.590] [info][savedobjects-service] [.kibana] UPDATE_TARGET_MAPPINGS -> UPDATE_TARGET_MAPPINGS_WAIT_FOR_TASK. took: 66ms.
[00:19:07]               │ info [o.e.t.LoggingTaskListener] [kibana-ci-immutable-centos-tests-xxl-1618838178515922555] 30649 finished with response BulkByScrollResponse[took=32.6ms,timed_out=false,sliceId=null,updated=12,created=0,deleted=0,batches=1,versionConflicts=0,noops=0,retries=0,throttledUntil=0s,bulk_failures=[],search_failures=[]]
[00:19:07]               │ proc [kibana]   log   [14:17:45.712] [info][savedobjects-service] [.kibana] UPDATE_TARGET_MAPPINGS_WAIT_FOR_TASK -> MARK_VERSION_INDEX_READY. took: 122ms.
[00:19:07]               │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-centos-tests-xxl-1618838178515922555] [.kibana_8.0.0_reindex_temp/A_qTOZFgR8WkVYjbJKTMMA] deleting index
[00:19:07]               │ proc [kibana]   log   [14:17:45.756] [info][savedobjects-service] [.kibana] MARK_VERSION_INDEX_READY -> DONE. took: 44ms.
[00:19:07]               │ proc [kibana]   log   [14:17:45.757] [info][savedobjects-service] [.kibana] Migration completed after 1616ms
[00:19:07]               │ debg [lens/basic] Migrated Kibana index after loading Kibana data
[00:19:07]               │ debg [lens/basic] Ensured that default space exists in .kibana
[00:19:07]               │ debg applying update to kibana config: {"accessibility:disableAnimations":true,"dateFormat:tz":"UTC","visualization:visualize:legacyChartsLibrary":true}
[00:19:09]               │ debg applying update to kibana config: {"accessibility:disableAnimations":true,"dateFormat:tz":"UTC","visualization:visualize:legacyChartsLibrary":true}
[00:19:10]             └-> should sync colors on dashboard by default
[00:19:10]               └-> "before each" hook: global before each for "should sync colors on dashboard by default"
[00:19:10]               │ debg navigating to dashboard url: http://localhost:61231/app/dashboards#/list
[00:19:10]               │ debg navigate to: http://localhost:61231/app/dashboards#/list
[00:19:10]               │ debg browser[INFO] http://localhost:61231/app/dashboards?_t=1618841868541#/list 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:19:10]               │
[00:19:10]               │ debg browser[INFO] http://localhost:61231/bootstrap.js 41:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:19:10]               │ debg ... sleep(700) start
[00:19:11]               │ debg ... sleep(700) end
[00:19:11]               │ debg returned from get, calling refresh
[00:19:11]               │ debg browser[INFO] http://localhost:61231/app/dashboards?_t=1618841868541#/list 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:19:11]               │
[00:19:11]               │ debg browser[INFO] http://localhost:61231/bootstrap.js 41:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:19:11]               │ debg currentUrl = http://localhost:61231/app/dashboards#/list
[00:19:11]               │          appUrl = http://localhost:61231/app/dashboards#/list
[00:19:11]               │ debg TestSubjects.find(kibanaChrome)
[00:19:11]               │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:19:12]               │ debg ... sleep(501) start
[00:19:13]               │ debg ... sleep(501) end
[00:19:13]               │ debg in navigateTo url = http://localhost:61231/app/dashboards#/list?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:now-15m,to:now))
[00:19:13]               │ debg TestSubjects.exists(statusPageContainer)
[00:19:13]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="statusPageContainer"]') with timeout=2500
[00:19:15]               │ debg --- retry.tryForTime error: [data-test-subj="statusPageContainer"] is not displayed
[00:19:16]               │ debg TestSubjects.click(createDashboardPromptButton)
[00:19:16]               │ debg Find.clickByCssSelector('[data-test-subj="createDashboardPromptButton"]') with timeout=10000
[00:19:16]               │ debg Find.findByCssSelector('[data-test-subj="createDashboardPromptButton"]') with timeout=10000
[00:19:16]               │ debg DashboardAddPanel.clickAddNewPanelButton
[00:19:16]               │ debg TestSubjects.click(dashboardAddNewPanelButton)
[00:19:16]               │ debg Find.clickByCssSelector('[data-test-subj="dashboardAddNewPanelButton"]') with timeout=10000
[00:19:16]               │ debg Find.findByCssSelector('[data-test-subj="dashboardAddNewPanelButton"]') with timeout=10000
[00:19:16]               │ debg ... sleep(500) start
[00:19:17]               │ debg ... sleep(500) end
[00:19:17]               │ debg isGlobalLoadingIndicatorVisible
[00:19:17]               │ debg TestSubjects.exists(globalLoadingIndicator)
[00:19:17]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:19:17]               │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:19:17]               │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:19:17]               │ debg lensPage.goToTimeRange()
[00:19:17]               │ debg TestSubjects.exists(noDataPopoverDismissButton)
[00:19:17]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="noDataPopoverDismissButton"]') with timeout=2500
[00:19:20]               │ debg --- retry.tryForTime error: [data-test-subj="noDataPopoverDismissButton"] is not displayed
[00:19:20]               │ debg Setting absolute range to Sep 19, 2015 @ 06:31:44.000 to Sep 23, 2015 @ 18:31:44.000
[00:19:20]               │ debg TestSubjects.exists(superDatePickerToggleQuickMenuButton)
[00:19:20]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="superDatePickerToggleQuickMenuButton"]') with timeout=20000
[00:19:20]               │ debg TestSubjects.exists(superDatePickerShowDatesButton)
[00:19:20]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="superDatePickerShowDatesButton"]') with timeout=2500
[00:19:20]               │ debg TestSubjects.click(superDatePickerShowDatesButton)
[00:19:20]               │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerShowDatesButton"]') with timeout=10000
[00:19:20]               │ debg Find.findByCssSelector('[data-test-subj="superDatePickerShowDatesButton"]') with timeout=10000
[00:19:20]               │ debg TestSubjects.exists(superDatePickerstartDatePopoverButton)
[00:19:20]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="superDatePickerstartDatePopoverButton"]') with timeout=2500
[00:19:20]               │ debg TestSubjects.click(superDatePickerendDatePopoverButton)
[00:19:20]               │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerendDatePopoverButton"]') with timeout=10000
[00:19:20]               │ debg Find.findByCssSelector('[data-test-subj="superDatePickerendDatePopoverButton"]') with timeout=10000
[00:19:20]               │ debg Find.findByCssSelector('div.euiPopover__panel-isOpen') with timeout=10000
[00:19:20]               │ debg TestSubjects.click(superDatePickerAbsoluteTab)
[00:19:20]               │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerAbsoluteTab"]') with timeout=10000
[00:19:20]               │ debg Find.findByCssSelector('[data-test-subj="superDatePickerAbsoluteTab"]') with timeout=10000
[00:19:21]               │ debg TestSubjects.click(superDatePickerAbsoluteDateInput)
[00:19:21]               │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[00:19:21]               │ debg Find.findByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[00:19:21]               │ debg TestSubjects.setValue(superDatePickerAbsoluteDateInput, Sep 23, 2015 @ 18:31:44.000)
[00:19:21]               │ debg TestSubjects.click(superDatePickerAbsoluteDateInput)
[00:19:21]               │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[00:19:21]               │ debg Find.findByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[00:19:21]               │ debg TestSubjects.click(superDatePickerstartDatePopoverButton)
[00:19:21]               │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerstartDatePopoverButton"]') with timeout=10000
[00:19:21]               │ debg Find.findByCssSelector('[data-test-subj="superDatePickerstartDatePopoverButton"]') with timeout=10000
[00:19:21]               │ debg Find.waitForElementStale with timeout=10000
[00:19:21]               │ debg Find.findByCssSelector('div.euiPopover__panel-isOpen') with timeout=10000
[00:19:21]               │ debg TestSubjects.click(superDatePickerAbsoluteTab)
[00:19:21]               │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerAbsoluteTab"]') with timeout=10000
[00:19:21]               │ debg Find.findByCssSelector('[data-test-subj="superDatePickerAbsoluteTab"]') with timeout=10000
[00:19:22]               │ debg TestSubjects.click(superDatePickerAbsoluteDateInput)
[00:19:22]               │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[00:19:22]               │ debg Find.findByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[00:19:22]               │ debg TestSubjects.setValue(superDatePickerAbsoluteDateInput, Sep 19, 2015 @ 06:31:44.000)
[00:19:22]               │ debg TestSubjects.click(superDatePickerAbsoluteDateInput)
[00:19:22]               │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[00:19:22]               │ debg Find.findByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[00:19:22]               │ debg TestSubjects.exists(superDatePickerApplyTimeButton)
[00:19:22]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="superDatePickerApplyTimeButton"]') with timeout=2500
[00:19:25]               │ debg --- retry.tryForTime error: [data-test-subj="superDatePickerApplyTimeButton"] is not displayed
[00:19:25]               │ debg TestSubjects.click(querySubmitButton)
[00:19:25]               │ debg Find.clickByCssSelector('[data-test-subj="querySubmitButton"]') with timeout=10000
[00:19:25]               │ debg Find.findByCssSelector('[data-test-subj="querySubmitButton"]') with timeout=10000
[00:19:25]               │ debg Find.waitForElementStale with timeout=10000
[00:19:25]               │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:19:25]               │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:19:26]               │ debg lensPage.configureDimension([object Object])
[00:19:26]               │ debg TestSubjects.click(lns-layerPanel-0 > lnsXY_yDimensionPanel > lns-empty-dimension)
[00:19:26]               │ debg Find.clickByCssSelector('[data-test-subj="lns-layerPanel-0"] [data-test-subj="lnsXY_yDimensionPanel"] [data-test-subj="lns-empty-dimension"]') with timeout=10000
[00:19:26]               │ debg Find.findByCssSelector('[data-test-subj="lns-layerPanel-0"] [data-test-subj="lnsXY_yDimensionPanel"] [data-test-subj="lns-empty-dimension"]') with timeout=10000
[00:19:36]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="lns-layerPanel-0"] [data-test-subj="lnsXY_yDimensionPanel"] [data-test-subj="lns-empty-dimension"])
[00:19:36]               │      Wait timed out after 10054ms
[00:19:36]               │ debg Find.findByCssSelector('[data-test-subj="lns-layerPanel-0"] [data-test-subj="lnsXY_yDimensionPanel"] [data-test-subj="lns-empty-dimension"]') with timeout=10000
[00:19:46]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="lns-layerPanel-0"] [data-test-subj="lnsXY_yDimensionPanel"] [data-test-subj="lns-empty-dimension"])
[00:19:46]               │      Wait timed out after 10035ms
[00:19:47]               │ debg Find.findByCssSelector('[data-test-subj="lns-layerPanel-0"] [data-test-subj="lnsXY_yDimensionPanel"] [data-test-subj="lns-empty-dimension"]') with timeout=10000
[00:19:57]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="lns-layerPanel-0"] [data-test-subj="lnsXY_yDimensionPanel"] [data-test-subj="lns-empty-dimension"])
[00:19:57]               │      Wait timed out after 10028ms
[00:19:57]               │ debg Find.findByCssSelector('[data-test-subj="lns-layerPanel-0"] [data-test-subj="lnsXY_yDimensionPanel"] [data-test-subj="lns-empty-dimension"]') with timeout=10000
[00:20:07]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="lns-layerPanel-0"] [data-test-subj="lnsXY_yDimensionPanel"] [data-test-subj="lns-empty-dimension"])
[00:20:07]               │      Wait timed out after 10023ms
[00:20:08]               │ debg Find.findByCssSelector('[data-test-subj="lns-layerPanel-0"] [data-test-subj="lnsXY_yDimensionPanel"] [data-test-subj="lns-empty-dimension"]') with timeout=10000
[00:20:18]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="lns-layerPanel-0"] [data-test-subj="lnsXY_yDimensionPanel"] [data-test-subj="lns-empty-dimension"])
[00:20:18]               │      Wait timed out after 10054ms
[00:20:18]               │ debg Find.findByCssSelector('[data-test-subj="lns-layerPanel-0"] [data-test-subj="lnsXY_yDimensionPanel"] [data-test-subj="lns-empty-dimension"]') with timeout=10000
[00:20:28]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="lns-layerPanel-0"] [data-test-subj="lnsXY_yDimensionPanel"] [data-test-subj="lns-empty-dimension"])
[00:20:28]               │      Wait timed out after 10039ms
[00:20:29]               │ debg Find.findByCssSelector('[data-test-subj="lns-layerPanel-0"] [data-test-subj="lnsXY_yDimensionPanel"] [data-test-subj="lns-empty-dimension"]') with timeout=10000
[00:20:39]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="lns-layerPanel-0"] [data-test-subj="lnsXY_yDimensionPanel"] [data-test-subj="lns-empty-dimension"])
[00:20:39]               │      Wait timed out after 10027ms
[00:20:39]               │ debg Find.findByCssSelector('[data-test-subj="lns-layerPanel-0"] [data-test-subj="lnsXY_yDimensionPanel"] [data-test-subj="lns-empty-dimension"]') with timeout=10000
[00:20:49]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="lns-layerPanel-0"] [data-test-subj="lnsXY_yDimensionPanel"] [data-test-subj="lns-empty-dimension"])
[00:20:49]               │      Wait timed out after 10057ms
[00:20:50]               │ debg Find.findByCssSelector('[data-test-subj="lns-layerPanel-0"] [data-test-subj="lnsXY_yDimensionPanel"] [data-test-subj="lns-empty-dimension"]') with timeout=10000
[00:21:00]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="lns-layerPanel-0"] [data-test-subj="lnsXY_yDimensionPanel"] [data-test-subj="lns-empty-dimension"])
[00:21:00]               │      Wait timed out after 10019ms
[00:21:00]               │ debg Find.findByCssSelector('[data-test-subj="lns-layerPanel-0"] [data-test-subj="lnsXY_yDimensionPanel"] [data-test-subj="lns-empty-dimension"]') with timeout=10000
[00:21:10]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="lns-layerPanel-0"] [data-test-subj="lnsXY_yDimensionPanel"] [data-test-subj="lns-empty-dimension"])
[00:21:10]               │      Wait timed out after 10040ms
[00:21:11]               │ debg Find.findByCssSelector('[data-test-subj="lns-layerPanel-0"] [data-test-subj="lnsXY_yDimensionPanel"] [data-test-subj="lns-empty-dimension"]') with timeout=10000
[00:21:21]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="lns-layerPanel-0"] [data-test-subj="lnsXY_yDimensionPanel"] [data-test-subj="lns-empty-dimension"])
[00:21:21]               │      Wait timed out after 10036ms
[00:21:21]               │ debg Find.findByCssSelector('[data-test-subj="lns-layerPanel-0"] [data-test-subj="lnsXY_yDimensionPanel"] [data-test-subj="lns-empty-dimension"]') with timeout=10000
[00:21:32]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="lns-layerPanel-0"] [data-test-subj="lnsXY_yDimensionPanel"] [data-test-subj="lns-empty-dimension"])
[00:21:32]               │      Wait timed out after 10047ms
[00:21:32]               │ debg --- retry.try error: retry.try timeout: TimeoutError: Waiting for element to be located By(css selector, [data-test-subj="lns-layerPanel-0"] [data-test-subj="lnsXY_yDimensionPanel"] [data-test-subj="lns-empty-dimension"])
[00:21:32]               │      Wait timed out after 10047ms
[00:21:32]               │          at /dev/shm/workspace/parallel/23/kibana/node_modules/selenium-webdriver/lib/webdriver.js:842:17
[00:21:32]               │          at runMicrotasks (<anonymous>)
[00:21:32]               │          at processTicksAndRejections (internal/process/task_queues.js:93:5)
[00:21:33]               │ info Taking screenshot "/dev/shm/workspace/parallel/23/kibana/x-pack/test/functional/screenshots/failure/dashboard sync colors should sync colors on dashboard by default.png"
[00:21:33]               │ info Current URL is: http://localhost:61231/app/dashboards#/create?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:%272015-09-19T06:31:44.000Z%27,to:%272015-09-23T18:31:44.000Z%27))&_a=(description:%27%27,filters:!(),fullScreenMode:!f,options:(hidePanelTitles:!f,useMargins:!t),query:(language:kuery,query:%27%27),tags:!(),timeRestore:!f,title:%27%27,viewMode:edit)
[00:21:33]               │ info Saving page source to: /dev/shm/workspace/parallel/23/kibana/x-pack/test/functional/failure_debug/html/dashboard sync colors should sync colors on dashboard by default.html
[00:21:33]               └- ✖ fail: dashboard sync colors should sync colors on dashboard by default
[00:21:33]               │      retry.try timeout: Error: retry.try timeout: TimeoutError: Waiting for element to be located By(css selector, [data-test-subj="lns-layerPanel-0"] [data-test-subj="lnsXY_yDimensionPanel"] [data-test-subj="lns-empty-dimension"])
[00:21:33]               │ Wait timed out after 10047ms
[00:21:33]               │     at /dev/shm/workspace/parallel/23/kibana/node_modules/selenium-webdriver/lib/webdriver.js:842:17
[00:21:33]               │     at runMicrotasks (<anonymous>)
[00:21:33]               │     at processTicksAndRejections (internal/process/task_queues.js:93:5)
[00:21:33]               │     at onFailure (/dev/shm/workspace/parallel/23/kibana/test/common/services/retry/retry_for_success.ts:17:9)
[00:21:33]               │     at retryForSuccess (/dev/shm/workspace/parallel/23/kibana/test/common/services/retry/retry_for_success.ts:57:13)
[00:21:33]               │     at Retry.try (/dev/shm/workspace/parallel/23/kibana/test/common/services/retry/retry.ts:32:14)
[00:21:33]               │     at Proxy.clickByCssSelector (/dev/shm/workspace/parallel/23/kibana/test/functional/services/common/find.ts:420:7)
[00:21:33]               │     at TestSubjects.click (/dev/shm/workspace/parallel/23/kibana/test/functional/services/common/test_subjects.ts:109:7)
[00:21:33]               │     at /dev/shm/workspace/parallel/23/kibana/x-pack/test/functional/page_objects/lens_page.ts:114:9
[00:21:33]               │     at runAttempt (/dev/shm/workspace/parallel/23/kibana/test/common/services/retry/retry_for_success.ts:27:15)
[00:21:33]               │     at retryForSuccess (/dev/shm/workspace/parallel/23/kibana/test/common/services/retry/retry_for_success.ts:66:21)
[00:21:33]               │     at Retry.try (/dev/shm/workspace/parallel/23/kibana/test/common/services/retry/retry.ts:32:14)
[00:21:33]               │     at Object.configureDimension (/dev/shm/workspace/parallel/23/kibana/x-pack/test/functional/page_objects/lens_page.ts:113:7)
[00:21:33]               │     at Context.<anonymous> (/dev/shm/workspace/parallel/23/kibana/x-pack/test/functional/apps/dashboard/sync_colors.ts:55:7)
[00:21:33]               │     at Object.apply (/dev/shm/workspace/parallel/23/kibana/node_modules/@kbn/test/src/functional_test_runner/lib/mocha/wrap_function.js:73:16)
[00:21:33]               │   Error: retry.try timeout: Error: retry.try timeout: TimeoutError: Waiting for element to be located By(css selector, [data-test-subj="lns-layerPanel-0"] [data-test-subj="lnsXY_yDimensionPanel"] [data-test-subj="lns-empty-dimension"])
[00:21:33]               │   Wait timed out after 10047ms
[00:21:33]               │       at /dev/shm/workspace/parallel/23/kibana/node_modules/selenium-webdriver/lib/webdriver.js:842:17
[00:21:33]               │       at runMicrotasks (<anonymous>)
[00:21:33]               │       at processTicksAndRejections (internal/process/task_queues.js:93:5)
[00:21:33]               │       at onFailure (/dev/shm/workspace/parallel/23/kibana/test/common/services/retry/retry_for_success.ts:17:9)
[00:21:33]               │       at retryForSuccess (/dev/shm/workspace/parallel/23/kibana/test/common/services/retry/retry_for_success.ts:57:13)
[00:21:33]               │       at Retry.try (/dev/shm/workspace/parallel/23/kibana/test/common/services/retry/retry.ts:32:14)
[00:21:33]               │       at Proxy.clickByCssSelector (/dev/shm/workspace/parallel/23/kibana/test/functional/services/common/find.ts:420:7)
[00:21:33]               │       at TestSubjects.click (/dev/shm/workspace/parallel/23/kibana/test/functional/services/common/test_subjects.ts:109:7)
[00:21:33]               │       at /dev/shm/workspace/parallel/23/kibana/x-pack/test/functional/page_objects/lens_page.ts:114:9
[00:21:33]               │       at runAttempt (/dev/shm/workspace/parallel/23/kibana/test/common/services/retry/retry_for_success.ts:27:15)
[00:21:33]               │       at retryForSuccess (/dev/shm/workspace/parallel/23/kibana/test/common/services/retry/retry_for_success.ts:66:21)
[00:21:33]               │       at Retry.try (/dev/shm/workspace/parallel/23/kibana/test/common/services/retry/retry.ts:32:14)
[00:21:33]               │       at Object.configureDimension (test/functional/page_objects/lens_page.ts:113:7)
[00:21:33]               │       at Context.<anonymous> (test/functional/apps/dashboard/sync_colors.ts:55:7)
[00:21:33]               │       at Object.apply (/dev/shm/workspace/parallel/23/kibana/node_modules/@kbn/test/src/functional_test_runner/lib/mocha/wrap_function.js:73:16)
[00:21:33]               │       at onFailure (/dev/shm/workspace/parallel/23/kibana/test/common/services/retry/retry_for_success.ts:17:9)
[00:21:33]               │       at retryForSuccess (/dev/shm/workspace/parallel/23/kibana/test/common/services/retry/retry_for_success.ts:57:13)
[00:21:33]               │       at Retry.try (/dev/shm/workspace/parallel/23/kibana/test/common/services/retry/retry.ts:32:14)
[00:21:33]               │       at Object.configureDimension (test/functional/page_objects/lens_page.ts:113:7)
[00:21:33]               │       at Context.<anonymous> (test/functional/apps/dashboard/sync_colors.ts:55:7)
[00:21:33]               │       at Object.apply (/dev/shm/workspace/parallel/23/kibana/node_modules/@kbn/test/src/functional_test_runner/lib/mocha/wrap_function.js:73:16)
[00:21:33]               │ 
[00:21:33]               │

Stack Trace

Error: retry.try timeout: Error: retry.try timeout: TimeoutError: Waiting for element to be located By(css selector, [data-test-subj="lns-layerPanel-0"] [data-test-subj="lnsXY_yDimensionPanel"] [data-test-subj="lns-empty-dimension"])
Wait timed out after 10047ms
    at /dev/shm/workspace/parallel/23/kibana/node_modules/selenium-webdriver/lib/webdriver.js:842:17
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at onFailure (/dev/shm/workspace/parallel/23/kibana/test/common/services/retry/retry_for_success.ts:17:9)
    at retryForSuccess (/dev/shm/workspace/parallel/23/kibana/test/common/services/retry/retry_for_success.ts:57:13)
    at Retry.try (/dev/shm/workspace/parallel/23/kibana/test/common/services/retry/retry.ts:32:14)
    at Proxy.clickByCssSelector (/dev/shm/workspace/parallel/23/kibana/test/functional/services/common/find.ts:420:7)
    at TestSubjects.click (/dev/shm/workspace/parallel/23/kibana/test/functional/services/common/test_subjects.ts:109:7)
    at /dev/shm/workspace/parallel/23/kibana/x-pack/test/functional/page_objects/lens_page.ts:114:9
    at runAttempt (/dev/shm/workspace/parallel/23/kibana/test/common/services/retry/retry_for_success.ts:27:15)
    at retryForSuccess (/dev/shm/workspace/parallel/23/kibana/test/common/services/retry/retry_for_success.ts:66:21)
    at Retry.try (/dev/shm/workspace/parallel/23/kibana/test/common/services/retry/retry.ts:32:14)
    at Object.configureDimension (test/functional/page_objects/lens_page.ts:113:7)
    at Context.<anonymous> (test/functional/apps/dashboard/sync_colors.ts:55:7)
    at Object.apply (/dev/shm/workspace/parallel/23/kibana/node_modules/@kbn/test/src/functional_test_runner/lib/mocha/wrap_function.js:73:16)
    at onFailure (/dev/shm/workspace/parallel/23/kibana/test/common/services/retry/retry_for_success.ts:17:9)
    at retryForSuccess (/dev/shm/workspace/parallel/23/kibana/test/common/services/retry/retry_for_success.ts:57:13)
    at Retry.try (/dev/shm/workspace/parallel/23/kibana/test/common/services/retry/retry.ts:32:14)
    at Object.configureDimension (test/functional/page_objects/lens_page.ts:113:7)
    at Context.<anonymous> (test/functional/apps/dashboard/sync_colors.ts:55:7)
    at Object.apply (/dev/shm/workspace/parallel/23/kibana/node_modules/@kbn/test/src/functional_test_runner/lib/mocha/wrap_function.js:73:16)

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`remoteClusters`	165.6KB	163.8KB	-1.9KB

History

💚 Build #119943 succeeded d598c61
💚 Build #119573 succeeded a3790b2
💚 Build #119279 succeeded cfc4991

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cuff-links

Tested locally. Code looks good to me. Great job, @yuliacech!

* Added a11y tests for Remote Clusters plugin and fixed discovered violations * Added an a11y test for a delete modal * Updated payload type casting Co-authored-by: Kibana Machine <[email protected]>

) * Added a11y tests for Remote Clusters plugin and fixed discovered violations * Added an a11y test for a delete modal * Updated payload type casting Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>

* Added a11y tests for Remote Clusters plugin and fixed discovered violations * Added an a11y test for a delete modal * Updated payload type casting Co-authored-by: Kibana Machine <[email protected]>

yuliacech added 2 commits April 13, 2021 17:20

Added a11y tests for Remote Clusters plugin and fixed discovered viol…

6d72743

…ations

Added an a11y test for a delete modal

cfc4991

yuliacech requested a review from a team as a code owner April 13, 2021 15:38

yuliacech added Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.13.0 v8.0.0 labels Apr 13, 2021

myasonik approved these changes Apr 13, 2021

View reviewed changes

yuliacech requested a review from cuff-links April 13, 2021 15:59

Merge branch 'master' into remote_clusters_a11y

a3790b2

yuliacech requested a review from sebelga April 14, 2021 14:39

sebelga approved these changes Apr 15, 2021

View reviewed changes

Updated payload type casting

38c69ad

Merge branch 'master' into remote_clusters_a11y

d598c61

Merge branch 'master' into remote_clusters_a11y

46ec5ec

cuff-links approved these changes Apr 19, 2021

View reviewed changes

yuliacech merged commit bd5e9ba into elastic:master Apr 20, 2021

yuliacech mentioned this pull request Apr 20, 2021

[7.x] [Remote Clusters] Added a11y tests and fixed violations (#96989) #97589

Merged

yuliacech deleted the remote_clusters_a11y branch April 22, 2021 15:37

cjcenizal added the Feature:CCR and Remote Clusters label Apr 30, 2021

cuff-links mentioned this pull request Jun 24, 2022

[meta] Accessibility tests #51456

Open

77 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Remote Clusters] Added a11y tests and fixed violations #96989

[Remote Clusters] Added a11y tests and fixed violations #96989

yuliacech commented Apr 13, 2021

elasticmachine commented Apr 13, 2021

elasticmachine commented Apr 13, 2021

myasonik left a comment

yuliacech commented Apr 14, 2021

sebelga left a comment

sebelga Apr 15, 2021

yuliacech commented Apr 15, 2021

yuliacech commented Apr 19, 2021

kibanamachine commented Apr 19, 2021

Standard Out

Stack Trace

cuff-links left a comment

[Remote Clusters] Added a11y tests and fixed violations #96989

[Remote Clusters] Added a11y tests and fixed violations #96989

Conversation

yuliacech commented Apr 13, 2021

Summary

Checklist

elasticmachine commented Apr 13, 2021

elasticmachine commented Apr 13, 2021

myasonik left a comment

Choose a reason for hiding this comment

yuliacech commented Apr 14, 2021

sebelga left a comment

Choose a reason for hiding this comment

sebelga Apr 15, 2021

Choose a reason for hiding this comment

yuliacech commented Apr 15, 2021

yuliacech commented Apr 19, 2021

kibanamachine commented Apr 19, 2021

💛 Build succeeded, but was flaky

Test Failures

Standard Out

Stack Trace

Metrics [docs]

Async chunks

History

cuff-links left a comment

Choose a reason for hiding this comment