Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discover: Limit field table rendering #97112

Closed

Conversation

flash1293
Copy link
Contributor

Based on #96765

Screenshot 2021-04-14 at 15 21 23

Only renders the first discover:maxDocFieldsDisplayed rows in the field table and a button to show all of them to speed up the UI.

I'm not sure whether this is that helpful. I imagine it can also be confusing because ctrl+F can't be used anymore to find a field in there. Also it's still pretty slow for really large number of fields (multiple thousands) - what do you think @kertal ? A really nice solution would probably be using data grid and virtualized scrolling.

This is meant as a quick fix for 7.13 if we decide to merge it

[skip ci]

@flash1293 flash1293 added Feature:Discover Discover Application enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 v7.13.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Apr 14, 2021
@kertal
Copy link
Member

kertal commented Apr 14, 2021

I'm not sure whether this is that helpful. I imagine it can also be confusing because ctrl+F can't be used anymore to find a field in there. Also it's still pretty slow for really large number of fields (multiple thousands) - what do you think @kertal ? A really nice solution would probably be using data grid and virtualized scrolling.

Thanks a lot & Good point @flash1293, so it improves performance, but on the other hand as you said it could break workflows for users like ctrl+F (I think we could add data grid and a custom search here, in general overwork)

Generally this solution would be a quick fix, as you said, also not sure if we shouldn't wait and go for a nice solution (we need also take care of multi field rendering), what do you think @timroes @majagrubic

@flash1293
Copy link
Contributor Author

Discussed this with @kertal and we decided this level of integration isn't providing much value, so closing this. We would prefer a switch to a paginated eui basic table with a field name search input on top. @kertal Is there an issue for this already?

@flash1293 flash1293 closed this Apr 15, 2021
@kertal kertal mentioned this pull request Apr 21, 2021
4 tasks
@kertal
Copy link
Member

kertal commented Apr 21, 2021

Discussed this with @kertal and we decided this level of integration isn't providing much value, so closing this. We would prefer a switch to a paginated eui basic table with a field name search input on top. @kertal Is there an issue for this already?

@flash1293 starting one to collect several tasks and todos targeting the doc viewer: #97649

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed enhancement New value added to drive a business result Feature:Discover Discover Application Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.13.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants