-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discover: Limit field table rendering #97112
Discover: Limit field table rendering #97112
Conversation
…cument-table-rendering
…cument-table-rendering
…cument-table-rendering
Thanks a lot & Good point @flash1293, so it improves performance, but on the other hand as you said it could break workflows for users like ctrl+F (I think we could add data grid and a custom search here, in general overwork) Generally this solution would be a quick fix, as you said, also not sure if we shouldn't wait and go for a nice solution (we need also take care of multi field rendering), what do you think @timroes @majagrubic |
@flash1293 starting one to collect several tasks and todos targeting the doc viewer: #97649 |
Based on #96765
Only renders the first
discover:maxDocFieldsDisplayed
rows in the field table and a button to show all of them to speed up the UI.I'm not sure whether this is that helpful. I imagine it can also be confusing because ctrl+F can't be used anymore to find a field in there. Also it's still pretty slow for really large number of fields (multiple thousands) - what do you think @kertal ? A really nice solution would probably be using data grid and virtualized scrolling.
This is meant as a quick fix for 7.13 if we decide to merge it
[skip ci]