Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for a RedHat init script #169

Closed
wants to merge 2 commits into from
Closed

Add support for a RedHat init script #169

wants to merge 2 commits into from

Conversation

adamcstephens
Copy link

extend make target to provide separate deb/rpm init scripts
rename debian script
add new redhat script

This could potentially fix issue #75, but I only tested on el6 and not Fedora.

I look forward to jordansissel/pleaserun :)

extend make target to provide separate deb/rpm init scripts
rename debian script
add new redhat script
@adamcstephens
Copy link
Author

This could replace #76 which was built towards lumberjack.

;;
esac

:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ':' seems to be misplaced

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It aliases to builtin true command which always return 0. It ensures the script exits 0, otherwise if last function to run returned bad status it will exit with it, which I think is not wanted.

Basically same as exit 0

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Face palm :-D
I need more sleep

@adamcstephens
Copy link
Author

Closing this. I'll work on using the base redhat functions instead.

@dwerder
Copy link

dwerder commented Apr 25, 2014

I also have a full redhat sysv compatible init script reqdy. But I can wait for your PR :-)

@adamcstephens
Copy link
Author

I'm going to have to modify and test it. If you are ready to submit,
please go ahead. :)

-adam

On Fri, Apr 25, 2014, at 11:35 AM, Daniel Werdermann wrote:

I also have a full redhat sysv compatible init script reqdy. But I
can wait for your PR :-)

Reply to this email directly or [1]view it on GitHub.
[2071575__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcxNDA3MDEyO
SwiZGF0YSI6eyJpZCI6MjYxMTMzMDl9fQ==--bcf07d9077cd718844fa993635c3d75262
348e34.gif]

References

  1. Add support for a RedHat init script #169 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants