Polish things up for release #402
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut is well-commented
…reate a new connection.
Runs an Ubuntu 14.04 docker image and installs the package and runs lsf pointed at our local lumberjack server. This test is currently breaking because we aren't generating an ssl certificate with an IP SAN.
Still trying to figure out how to reliably generate an ssl certificate that has an IP SAN. Might give up and use /etc/hosts instead.
`go build` by default compiles the main package into a binary named the same as the current directory. Sometimes folks do things to cause this directory to not be named "logstash-forwarder" (for example, as reported in #388). This change makes all `go build` documentation/invocations force the output binary name to be "logstash-forwarder" regardless of the parent directory name.
This allows tests to run under JRuby
This should solve this error that occurs during deb removal:
update-rc.d: /etc/init.d/logstash-forwarder exists during rc.d purge (use -f to force)
* Now logs to /var/log/logstash-forwarder/... * Now runs in /var/lib/logstash-forwarder/...
I would do this in the `/etc/init.d/logstash-forwarder start` output, but I'm pretty sure systems like puppet/chef/etc rely on specific confines of the output of init scripts, so there's probably nothing we can output there. I'd love to know if this isn't true.
|
Testing locally.. |
Attempt to satisfy #400
This was referenced Mar 3, 2015
|
Merged sucessfully into master! |
jordansissel
added a commit
that referenced
this pull request
Mar 4, 2015
…reate a new connection. Fixes #402
jordansissel
added a commit
that referenced
this pull request
Mar 4, 2015
jordansissel
added a commit
that referenced
this pull request
Mar 4, 2015
Runs an Ubuntu 14.04 docker image and installs the package and runs lsf pointed at our local lumberjack server. This test is currently breaking because we aren't generating an ssl certificate with an IP SAN. Fixes #402
jordansissel
added a commit
that referenced
this pull request
Mar 4, 2015
Still trying to figure out how to reliably generate an ssl certificate that has an IP SAN. Might give up and use /etc/hosts instead. Fixes #402
jordansissel
added a commit
that referenced
this pull request
Mar 4, 2015
`go build` by default compiles the main package into a binary named the same as the current directory. Sometimes folks do things to cause this directory to not be named "logstash-forwarder" (for example, as reported in #388). This change makes all `go build` documentation/invocations force the output binary name to be "logstash-forwarder" regardless of the parent directory name. Fixes #402
jordansissel
added a commit
that referenced
this pull request
Mar 4, 2015
jordansissel
added a commit
that referenced
this pull request
Mar 4, 2015
This allows tests to run under JRuby Fixes #402
jordansissel
added a commit
that referenced
this pull request
Mar 4, 2015
jordansissel
added a commit
that referenced
this pull request
Mar 4, 2015
This should solve this error that occurs during deb removal:
update-rc.d: /etc/init.d/logstash-forwarder exists during rc.d purge (use -f to force)
Fixes #402
jordansissel
added a commit
that referenced
this pull request
Mar 4, 2015
jordansissel
added a commit
that referenced
this pull request
Mar 4, 2015
* Now logs to /var/log/logstash-forwarder/... * Now runs in /var/lib/logstash-forwarder/... Fixes #402
jordansissel
added a commit
that referenced
this pull request
Mar 4, 2015
I would do this in the `/etc/init.d/logstash-forwarder start` output, but I'm pretty sure systems like puppet/chef/etc rely on specific confines of the output of init scripts, so there's probably nothing we can output there. I'd love to know if this isn't true. Fixes #402
This was referenced Mar 4, 2015
ph
pushed a commit
to elastic/ruby-lumberjack
that referenced
this pull request
May 7, 2015
…reate a new connection. Fixes elastic/logstash-forwarder#402
ph
pushed a commit
to elastic/ruby-lumberjack
that referenced
this pull request
May 7, 2015
Runs an Ubuntu 14.04 docker image and installs the package and runs lsf pointed at our local lumberjack server. This test is currently breaking because we aren't generating an ssl certificate with an IP SAN. Fixes elastic/logstash-forwarder#402
ph
pushed a commit
to elastic/ruby-lumberjack
that referenced
this pull request
May 7, 2015
Still trying to figure out how to reliably generate an ssl certificate that has an IP SAN. Might give up and use /etc/hosts instead. Fixes elastic/logstash-forwarder#402
ph
pushed a commit
to elastic/ruby-lumberjack
that referenced
this pull request
May 7, 2015
ph
pushed a commit
to elastic/ruby-lumberjack
that referenced
this pull request
May 7, 2015
This allows tests to run under JRuby Fixes elastic/logstash-forwarder#402
justmara
pushed a commit
to justmara/logstash-forwarder
that referenced
this pull request
May 28, 2015
…ut is well-commented Fixes elastic#402
justmara
pushed a commit
to justmara/logstash-forwarder
that referenced
this pull request
May 28, 2015
…reate a new connection. Fixes elastic#402
justmara
pushed a commit
to justmara/logstash-forwarder
that referenced
this pull request
May 28, 2015
justmara
pushed a commit
to justmara/logstash-forwarder
that referenced
this pull request
May 28, 2015
Runs an Ubuntu 14.04 docker image and installs the package and runs lsf pointed at our local lumberjack server. This test is currently breaking because we aren't generating an ssl certificate with an IP SAN. Fixes elastic#402
justmara
pushed a commit
to justmara/logstash-forwarder
that referenced
this pull request
May 28, 2015
Still trying to figure out how to reliably generate an ssl certificate that has an IP SAN. Might give up and use /etc/hosts instead. Fixes elastic#402
justmara
pushed a commit
to justmara/logstash-forwarder
that referenced
this pull request
May 28, 2015
`go build` by default compiles the main package into a binary named the same as the current directory. Sometimes folks do things to cause this directory to not be named "logstash-forwarder" (for example, as reported in elastic#388). This change makes all `go build` documentation/invocations force the output binary name to be "logstash-forwarder" regardless of the parent directory name. Fixes elastic#402
justmara
pushed a commit
to justmara/logstash-forwarder
that referenced
this pull request
May 28, 2015
justmara
pushed a commit
to justmara/logstash-forwarder
that referenced
this pull request
May 28, 2015
This allows tests to run under JRuby Fixes elastic#402
justmara
pushed a commit
to justmara/logstash-forwarder
that referenced
this pull request
May 28, 2015
justmara
pushed a commit
to justmara/logstash-forwarder
that referenced
this pull request
May 28, 2015
justmara
pushed a commit
to justmara/logstash-forwarder
that referenced
this pull request
May 28, 2015
Fixes elastic#402
justmara
pushed a commit
to justmara/logstash-forwarder
that referenced
this pull request
May 28, 2015
This should solve this error that occurs during deb removal:
update-rc.d: /etc/init.d/logstash-forwarder exists during rc.d purge (use -f to force)
Fixes elastic#402
justmara
pushed a commit
to justmara/logstash-forwarder
that referenced
this pull request
May 28, 2015
justmara
pushed a commit
to justmara/logstash-forwarder
that referenced
this pull request
May 28, 2015
* Now logs to /var/log/logstash-forwarder/... * Now runs in /var/lib/logstash-forwarder/... Fixes elastic#402
justmara
pushed a commit
to justmara/logstash-forwarder
that referenced
this pull request
May 28, 2015
I would do this in the `/etc/init.d/logstash-forwarder start` output, but I'm pretty sure systems like puppet/chef/etc rely on specific confines of the output of init scripts, so there's probably nothing we can output there. I'd love to know if this isn't true. Fixes elastic#402
justmara
pushed a commit
to justmara/logstash-forwarder
that referenced
this pull request
May 28, 2015
Attempt to satisfy elastic#400 Fixes elastic#402
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make logstash-forwardernow is agnostic as to the parent directory name for folks who don'tgit clonenormally.I tested this by hand on CentOS 7 and Ubuntu 14.04:
go testpassesrspecpasseslogstash-forwarderuser