tests: support more-precise clocks in Java 11 #10381
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
targets:
master
,6.x
(same targets as Java Plugin API that introduced these tests).In Java 8,
java.lang.Instant#now()
used the system clock, which only had millisecond-level precision, but starting with Java 9, the system clock is much more precise.Since we create our
org.logstash.Timestamp
withlong epoch_milliseconds
, it cannot represent a time more precisely than milliseconds.Ensure that the output of
Timestamp#usec
is rounded before comparing it with milliseconds, in order to avoid asserting greater precision than we can create.