Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialise receiver/elasticapmreceiver #191

Merged
merged 10 commits into from
Oct 24, 2024
Merged

Conversation

axw
Copy link
Member

@axw axw commented Oct 22, 2024

Create a skeleton for the elasticapm receiver, for receiving data from Elastic APM/RUM agents.

@axw axw requested a review from a team as a code owner October 22, 2024 11:49
@AlexanderWert
Copy link
Member

cc @rogercoll

Copy link
Contributor

@rogercoll rogercoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(some CI checks failing, should be fixed by running make license-update)

Skeleton looks great to me. I think it would be interesting to start with the following in a follow-up PR:

Copy link
Contributor

@lahsivjar lahsivjar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

receiver/elasticapmreceiver/metadata.yaml Show resolved Hide resolved
receiver/elasticapmreceiver/receiver.go Outdated Show resolved Hide resolved
@lahsivjar
Copy link
Contributor

lahsivjar commented Oct 23, 2024

@axw Also, looks like the mdatagen used to generate the code is old. You may need to update that in you local. OTOH, I think there is something wrong with the tools setup of mdatagen in the repository... it seems to use the global one.

axw and others added 3 commits October 24, 2024 10:21
@axw
Copy link
Member Author

axw commented Oct 24, 2024

@axw Also, looks like the mdatagen used to generate the code is old. You may need to update that in you local. OTOH, I think there is something wrong with the tools setup of mdatagen in the repository... it seems to use the global one.

Indeed, I've pushed a fix to Makefile.Common to add the tools dir to $PATH

@axw axw merged commit 53e0ecf into elastic:main Oct 24, 2024
11 checks passed
@axw axw deleted the init-elasticapm branch October 24, 2024 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants