-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initialise receiver/elasticapmreceiver #191
Conversation
cc @rogercoll |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(some CI checks failing, should be fixed by running make license-update
)
Skeleton looks great to me. I think it would be interesting to start with the following in a follow-up PR:
- Translators: move the APM Event to Otel pdata translations to a custom package. Similar to https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/pkg/translator/opencensus
- Do you know if there is any repository/source where we can get json
modelpb.Batch
examples for unit testing?
- Do you know if there is any repository/source where we can get json
- README.md with support matrix
testdata
: Integration test with the expected generated signals
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@axw Also, looks like the |
Co-authored-by: Vishal Raj <[email protected]>
Make sure we use the pinned versions of mdatagen etc.
Indeed, I've pushed a fix to Makefile.Common to add the tools dir to $PATH |
Create a skeleton for the
elasticapm
receiver, for receiving data from Elastic APM/RUM agents.