Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stream fields to each dataset #296

Merged
merged 2 commits into from
Mar 25, 2020
Merged

Conversation

ruflin
Copy link
Member

@ruflin ruflin commented Mar 24, 2020

During the generation of the datasets, a stream.yml file is created with the stream fields inside. These are required for each dataset.

@ruflin ruflin self-assigned this Mar 24, 2020
@ruflin
Copy link
Member Author

ruflin commented Mar 24, 2020

This PR requires #295 to be merged first.

@neptunian @skh This adds the stream fields to each dataset. With this, EPM does not have to do anything special. I checked and it looks like template generation and index pattern generation works with the fields. On the index pattern side: Are constant_keyword fields just treated as keyword or does KB have support for it already?

@ruflin ruflin requested a review from mtojek March 24, 2020 12:24
@neptunian
Copy link
Contributor

neptunian commented Mar 24, 2020

@ruflin for index patterns there is no support for the constant_keyword field. if the type is unknown, it should not be set, so the field would have no type set. For mappings, if it doesn't recognize the type, it just passes it through. I created an issue to support it here elastic/kibana#61112 . keyword is converted to a string for index patterns, I imagine we will do the same for constant_keyword?

@ruflin
Copy link
Member Author

ruflin commented Mar 25, 2020

@neptunian Is it ok to merge this PR as I think it does not break anything at the moment?

Moving the other conversation to elastic/kibana#61112

@neptunian
Copy link
Contributor

yes, it won't break anything.

During the generation of the datasets, a stream.yml file is created with the stream fields inside. These are required for each dataset.
@ruflin ruflin merged commit 6e05fcc into elastic:master Mar 25, 2020
@ruflin ruflin deleted the add-stream-fields branch March 25, 2020 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants