Support Terraform deployment files #111
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
|
| name: deploy | ||
| required: false | ||
| $ref: "./../../_dev/deploy/spec.yml" # Use "deploy" spec for package |
There was a problem hiding this comment.
Is this what we want? It implies that there can be data stream level deployment definitions for Docker Compose-based deployments as well, not just Terraform-based deployments. Having such consistency is really nice but I want to make sure it's something that's actually going to be supported by elastic-package as well. Otherwise the spec is a bit misleading.
There was a problem hiding this comment.
Yes, I modified the elastic-package here: elastic/elastic-package#228 .
As you noticed, It means that we will support deploy definitions on the data stream level. Actually we may leverage from this change, as currently developers build a single Docker image for multiple data streams. See: https://github.com/elastic/integrations/tree/master/packages/zeek/_dev/deploy/docker
If you prefer to support tf only, I can adjust the spec.
There was a problem hiding this comment.
Ah nice, I hadn't studied elastic/elastic-package#228 in depth before, sorry! Given what you have there, what you have here is good as-is. Thanks!
|
I will solve all conflicts ( |
* Adding apache test package * Fixing filenames * Adding system test config for apache/error dataset * Only sleep before destructing in debug mode * WIP: testing a fake host variable name * Fleshing out config * Updating parsing logic * Alternative parsing * Fixing syntax for array item lookup * Adding delete test policy handler * Adding Port to service context * Using Port from service context * Consistent terminology * Fixing some naming * Fixing more naming * Reducing teardown sleep duration * Adding explanatory comment
What does this PR do?
This PR introduces new Terraform-based deployment service definitions. Deployment definitions will enabled for both data stream and package (reuse).
Why is it important?
We're moving on with service deployer for AWS, GCP, etc.
Checklist
code/go/internal/validator/test/packagesthat prove my change is effective.versions/N/changelog.yml.Related issues