Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Only set discovery seed hosts if greater than 1" #78

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

pquentin
Copy link
Member

Reverts #77

As soon as this was merged, this broke our nightly benchmarks with the following error message:

[2023-01-18T11:56:56,877][INFO ][o.e.t.TransportService ] [rally-node-0] publish_address {192.168.20.29:9300}, bound_addresses {192.168.20.29:9300}
[2023-01-18T11:56:56,985][INFO ][o.e.b.BootstrapChecks ] [rally-node-0] bound or publishing to a non-loopback address, enforcing bootstrap checks
bootstrap check failure [1] of [1]: the default discovery settings are unsuitable for production use; at least one of [discovery.seed_hosts, discovery.seed_providers, cluster.initial_master_nodes] must be configured

Indeed, the way Elasticsearch differentiates development vs. production mode is the address that Elasticsearch is bound to, not the number of nodes in the cluster: https://www.elastic.co/guide/en/elasticsearch/reference/8.6/bootstrap-checks.html#dev-vs-prod-mode

cc @inqueue @danielmitterdorfer for awareness

@pquentin pquentin added the bug label Jan 18, 2023
@pquentin pquentin requested a review from inqueue January 18, 2023 11:54
@pquentin pquentin self-assigned this Jan 18, 2023
@pquentin pquentin merged commit 3a6f402 into master Jan 18, 2023
@pquentin pquentin deleted the revert-77-issue-1644-single-node-cl-discovery branch January 18, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant