-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add track for sub-bucket-aggs #114
Conversation
Adds a rally track specifically for testing the performance of the terms agg as I'll be doing some work on it. In particular this focuses on numeric terms because the first phase of my work only touches them. Relates to elastic/elasticsearch#55873
Adding this link for general awareness re: aggs tuning https://www.elastic.co/blog/improving-the-performance-of-high-cardinality-terms-aggregations-in-elasticsearch |
I have an addition to this for elastic/elasticsearch#56921 which makes it more like a track for "sort of complex aggs". I can certainly hold off on pushing it so as to not get in the way of review for this though. |
I've added a couple more things to check now that I'm further in this process. |
Ill check them out. I tested the original 3 queries, and found that you can lower the interval on 2 of them and it still works reliably.
I will test w/ the new queries before going and recommending that you change those, though. |
@hub-cap I've made your changes locally and am playing with some more. |
cool, im going to also tweak the new tasks youve added, to see if we can get a bit more throughput out of them |
I just finished a run with the new throughput you suggested and they choke up Elasticsearch on my desktop a bit:
It doesn't fall over but it ain't so happy. |
oh, indeed they do choke up on the local, im using a multiple machine setup. Ill circle back to find out which of these scenarios is what we should commit to the repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, but names need to be kebap case and not snake case
I've stabbed my words. |
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trailing newline pls
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
disregard i dumb.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Me too! What a coincidence!
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
disregard i dumb.
Adds a rally track specifically for testing the performance of the bucket aggs when they are "sub" aggs. Relates to elastic/elasticsearch#55873
Adds a rally track specifically for testing the performance of the bucket aggs when they are "sub" aggs. Relates to elastic/elasticsearch#55873
Adds a rally track specifically for testing the performance of the bucket aggs when they are "sub" aggs. Relates to elastic/elasticsearch#55873
Adds a rally track specifically for testing the performance of the terms
agg as I'll be doing some work on it. In particular this focuses on
numeric terms because the first phase of my work only touches them.
Relates to elastic/elasticsearch#55873