Skip to content

Commit

Permalink
Fix rally start when auto update gets triggered
Browse files Browse the repository at this point in the history
When auto update gets triggered (i.e. there are no local changes) the
function install_esrally_with_setuptools() fails as no parameter gets
passed at that point.

Make optional parameter detection more resilient in bash function.
  • Loading branch information
dliappis committed Apr 4, 2018
1 parent bc8bdca commit 24fea1d
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions run.sh
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ readonly HUMAN_NAME="${__RALLY_INTERNAL_HUMAN_NAME}"

install_esrally_with_setuptools () {
# Check if optional parameter with Rally binary path, points to an existing executable file.
if [[ -n ${1} ]]; then
if [[ -f ${1} && -x ${1} ]]; then return; fi
if [[ $# -ge 1 && -n $1 ]]; then
if [[ -f $1 && -x $1 ]]; then return; fi
fi

if [[ ${IN_VIRTUALENV} == 0 ]]; then
Expand Down

0 comments on commit 24fea1d

Please sign in to comment.