Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove automatic index management #380

Closed
danielmitterdorfer opened this issue Dec 8, 2017 · 0 comments
Closed

Remove automatic index management #380

danielmitterdorfer opened this issue Dec 8, 2017 · 0 comments
Labels
breaking Non-backwards compatible change enhancement Improves the status quo :Track Management New operations, changes in the track format, track download changes and the like
Milestone
0.10.0

Comments

@danielmitterdorfer
Copy link
Member

danielmitterdorfer commented Dec 8, 2017 •
edited
Loading

Historically, Rally has shipped only with a few core operations. Also, previous Rally versions have hard-coded the index management operations. At the beginning of a benchmark, Rally always did the following operations:

  1. Delete and recreate all index template in the templates section of the track
  2. Delete and recreate all indices that are defined in the indices section of the track
  3. Check cluster health == green

Although doable, it was hard for users to manage indices themselves (with custom operations).

With the recent work in #293 and #361, users can just specify flexibly what they need and let Rally just execute these operations.

In the course of this ticket we will also remove the deprecated command line option --cluster-health which will be replaced by the track parameter mechanism (see #310).

Marked as breaking because users need to adjust their existing tracks so this will work.
@danielmitterdorfer danielmitterdorfer added :Track Management New operations, changes in the track format, track download changes and the like breaking Non-backwards compatible change enhancement Improves the status quo labels Dec 8, 2017
@danielmitterdorfer danielmitterdorfer added this to the 0.9.x milestone Dec 8, 2017
@danielmitterdorfer danielmitterdorfer mentioned this issue Dec 8, 2017
Closed
@danielmitterdorfer danielmitterdorfer modified the milestones: 0.9.x, 0.10.0 Dec 11, 2017
danielmitterdorfer added a commit to danielmitterdorfer/rally-tracks that referenced this issue Apr 5, 2018
@danielmitterdorfer
Switch to explicit index management
7b899a7 
With this commit we switch all tracks to explicit index management
(instead of index auto-management). As this change is breaking, we also
increase the track version from 1 to 2 thus requiring at least Rally
0.9.0 to use these tracks.
This allows us to also remove some legacy codd that has registered the
`refresh` operation for older versions of Rally (newer versions already
include this operation in Rally core).

Relates elastic/rally#380
Closes elastic#37
@danielmitterdorfer danielmitterdorfer mentioned this issue Apr 5, 2018
Merged
danielmitterdorfer added a commit to danielmitterdorfer/rally that referenced this issue Apr 5, 2018
@danielmitterdorfer
Remove automatic index management
a2ec82f 
With this commit we remove the ability that Rally automatically deletes
and creates indices and users need to add explicit tasks now to their
tracks in order to make this work.

The rationale behind all this work is that we want the core of Rally to
be agnostic to the tasks that it executes.

Closes elastic#380
@danielmitterdorfer danielmitterdorfer mentioned this issue Apr 5, 2018
Merged
danielmitterdorfer added a commit to elastic/rally-tracks that referenced this issue Apr 6, 2018
@danielmitterdorfer
Switch to explicit index management
6477977 
With this commit we switch all tracks to explicit index management
(instead of index auto-management). As this change is breaking, we also
increase the track version from 1 to 2 thus requiring at least Rally
0.9.0 to use these tracks.
This allows us to also remove some legacy codd that has registered the
`refresh` operation for older versions of Rally (newer versions already
include this operation in Rally core).

Relates elastic/rally#380
Closes #37
Relates #41
danielmitterdorfer added a commit that referenced this issue Apr 6, 2018
@danielmitterdorfer
Remove automatic index management
76b29cc 
With this commit we remove the ability that Rally automatically deletes
and creates indices and users need to add explicit tasks now to their
tracks in order to make this work.

The rationale behind all this work is that we want the core of Rally to
be agnostic to the tasks that it executes.

Closes #380
Relates #456
danielmitterdorfer added a commit to elastic/rally-tracks that referenced this issue Apr 6, 2018
@danielmitterdorfer
Switch to explicit index management
c23ef39 
With this commit we switch all tracks to explicit index management
(instead of index auto-management). As this change is breaking, we also
increase the track version from 1 to 2 thus requiring at least Rally
0.9.0 to use these tracks.
This allows us to also remove some legacy codd that has registered the
`refresh` operation for older versions of Rally (newer versions already
include this operation in Rally core).

Relates elastic/rally#380
Closes #37
Relates #41
danielmitterdorfer added a commit to elastic/rally-tracks that referenced this issue Apr 6, 2018
@danielmitterdorfer
Switch to explicit index management
735b9a1 
With this commit we switch all tracks to explicit index management
(instead of index auto-management). As this change is breaking, we also
increase the track version from 1 to 2 thus requiring at least Rally
0.9.0 to use these tracks.
This allows us to also remove some legacy codd that has registered the
`refresh` operation for older versions of Rally (newer versions already
include this operation in Rally core).

Relates elastic/rally#380
Closes #37
Relates #41
danielmitterdorfer added a commit to elastic/rally-tracks that referenced this issue Apr 6, 2018
@danielmitterdorfer
Switch to explicit index management
ec047f6 
With this commit we switch all tracks to explicit index management
(instead of index auto-management). As this change is breaking, we also
increase the track version from 1 to 2 thus requiring at least Rally
0.9.0 to use these tracks.
This allows us to also remove some legacy codd that has registered the
`refresh` operation for older versions of Rally (newer versions already
include this operation in Rally core).

Relates elastic/rally#380
Closes #37
Relates #41
danielmitterdorfer added a commit to danielmitterdorfer/rally that referenced this issue Apr 11, 2018
@danielmitterdorfer
Require at least Rally 0.7.3 for config migration
4cee7ce 
With this commit we remove outdated config migration code. As our tracks
require at least Rally 0.9.0 now as of the recent cleanup (see elastic#380), we
remove all migration code for config version 11 and below (that is
versions older than Rally 0.7.3).
@danielmitterdorfer danielmitterdorfer mentioned this issue Apr 11, 2018
Merged
danielmitterdorfer added a commit that referenced this issue Apr 11, 2018
@danielmitterdorfer
Require at least Rally 0.7.3 for config migration
b71879f 
With this commit we remove outdated config migration code. As our tracks
require at least Rally 0.9.0 now as of the recent cleanup (see #380), we
remove all migration code for config version 11 and below (that is
versions older than Rally 0.7.3).

Relates #468
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking Non-backwards compatible change enhancement Improves the status quo :Track Management New operations, changes in the track format, track download changes and the like
Projects
None yet
Milestone
0.10.0
Development

No branches or pull requests
1 participant
@danielmitterdorfer