Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation and offline dist improvements #1043

Merged
merged 1 commit into from
Aug 3, 2020

Conversation

dliappis
Copy link
Contributor

Improve error message during offline installation, if Python3 or pip3
are missing.

Also due to native dependencies, make the offline package Linux specific
adding the necessary checks.

Finally, update the installation instructions to use Python3 best
practices.

Relates #1032
Closes #1034

Improve error message during offline installation, if Python3 or pip3
are missing.

Also due to native dependencies, make the offline package Linux specific
 adding the necessary checks.

Finally, update the installation instructions to use Python3 best
practices.

Relates elastic#1032
Closes elastic#1034
@dliappis dliappis added bug Something's wrong :Docs Changes to the documentation :Packaging Installation issues or packaging problems labels Jul 30, 2020
@dliappis dliappis added this to the 2.0.1 milestone Jul 30, 2020
@dliappis dliappis self-assigned this Jul 30, 2020

Depending on your system setup you may need to prepend this command with ``sudo``.
1. Ensure ``~/.local/bin`` is in your ``$PATH``.
2. Install Rally: ``python3 -m pip install --user esrally``.
Copy link
Contributor Author

@dliappis dliappis Jul 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively --user can be skipped and then esrally lives (in the form of a pyenv shim) in ~/.pyenv/shims/esrally. In this case the user would still need to either logout/login or exec $SHELL to make the shim active.

Since we are anyway upgrading pip (earlier) in a --user context, I think we should stick to that convention, which IMHO is a better practice, cleaner approach and ultimately a more discoverable location (~/.local/bin) for binaries to be stored. The requirement to have ~/.local/bin is also IMHO a best practice that users should follow.

All these instructions have been tested -- at least -- in CentOS 8 and Ubuntu 18.04. More testing very welcome.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, let's keep this as you've done it here.

Copy link
Contributor

@ebadyano ebadyano Jul 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for some reason python3 -m pip install --user esrally keeps installing 1.4.1 rally for me on Linux SUSE

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh i think that's because python version is 3.6 not 3.8

@dliappis dliappis linked an issue Jul 30, 2020 that may be closed by this pull request
@hub-cap
Copy link
Contributor

hub-cap commented Jul 30, 2020

Im testing this now, but ive noticed a bit about needing a JVM in the readme for running ES. Is this still true? Im trying it w/o one.

Copy link
Contributor

@hub-cap hub-cap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this with an archlinux container. Looks good to me, but ofc Id love to see others test this as well, so im not going to approve it yet. But this is my sign of approval.

3. Decompress the installation package with ``tar -xzf esrally-dist-*.tar.gz``.
4. Run the install script with ``sudo ./esrally-dist-*/install.sh``.
3. Decompress the installation package with ``tar -xzf esrally-dist-linux-*.tar.gz``.
4. Run the install script with ``sudo ./esrally-dist-linux-*/install.sh``.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linux- portion of the file is not present on the release link above.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, should this be offline-install.sh ? Ahh it looks like we sed in teh values in the offline-install for the release version, and then its just install.sh.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linux- portion of the file is not present on the release link above.

(If I understand the question correctly): Yeah it's not present now, but it will be after we release in the future due the changes here

@hub-cap
Copy link
Contributor

hub-cap commented Jul 30, 2020

I also confirmed that the java stuff is still required :) Rally did not like me installing 7.8.1 without a JAVA_HOME !!

Copy link
Member

@danielmitterdorfer danielmitterdorfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked fine for me. Thanks for improving this. LGTM


Depending on your system setup you may need to prepend this command with ``sudo``.
1. Ensure ``~/.local/bin`` is in your ``$PATH``.
2. Install Rally: ``python3 -m pip install --user esrally``.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, let's keep this as you've done it here.

Copy link
Contributor

@ebadyano ebadyano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it on RHEL. Thank you!

@dliappis dliappis merged commit b7301d3 into elastic:master Aug 3, 2020
@dliappis dliappis deleted the offline-installation-fixes branch August 3, 2020 11:30
@dliappis
Copy link
Contributor Author

dliappis commented Aug 3, 2020

Thanks everyone for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something's wrong :Docs Changes to the documentation :Packaging Installation issues or packaging problems
Projects
None yet
4 participants