Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for FOSSA #1108

Merged
merged 2 commits into from
Nov 10, 2020
Merged

Conversation

danielmitterdorfer
Copy link
Member

With this commit we add support in Rally to run license checks on third-party
dependencies with a separate tool called fossa. Note that this work is only a
preparation on the Rally side. This is intended to be run in CI and needs to be
supplemented by a corresponding CI job.

@danielmitterdorfer danielmitterdorfer added enhancement Improves the status quo :misc Changes that don't affect users directly: linter fixes, test improvements, etc. labels Nov 4, 2020
@danielmitterdorfer danielmitterdorfer added this to the 2.0.3 milestone Nov 4, 2020
@danielmitterdorfer danielmitterdorfer self-assigned this Nov 4, 2020
@hub-cap
Copy link
Contributor

hub-cap commented Nov 5, 2020

I am going to spin up a test machine to ensure this works properly

@elasticmachine run tests

Copy link
Contributor

@hub-cap hub-cap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. It complained about an environment variable but I dont think that needs to be solved in this PR.

My only question is ive seen some projects make the project field the entire github URL, whereas some do not. I dont know enought about fossa to know what is correct, and I assume you do :)

@hub-cap
Copy link
Contributor

hub-cap commented Nov 5, 2020

Not sure how I could have altered the tests by being on the machine but Im going to rerun them just in case on a pristine machine that I do not get on.

@elasticmachine run tests

@danielmitterdorfer
Copy link
Member Author

Thanks for the review!

This looks good. It complained about an environment variable but I dont think that needs to be solved in this PR.

I checked the logs from the CI run as well and I think this is because I've created this PR before #1105 has been merged to master. I've merged master now and retriggered a CI run.

My only question is ive seen some projects make the project field the entire github URL, whereas some do not. I dont know enought about fossa to know what is correct, and I assume you do :)

The Github URL is autopopulated when you create a fossa configuration on the command line (with fossa init) and this property is used in the fossa UI to identify the project (see also their docs). I've explicitly changed this so it shows the nicer name "Rally" instead of the somewhat clunky URL. I hope that answers your question.

@danielmitterdorfer danielmitterdorfer merged commit 51ebae5 into elastic:master Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves the status quo :misc Changes that don't affect users directly: linter fixes, test improvements, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants