Ensure admin tasks are always executed #1116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a user specified `--exclude-tasks`, Rally did not only exclude the specified tasks but also all administrative tasks. This happened because of a broken logic that always added an admin task filter internally. Due to another bug, administrative tasks where never correctly detected but we fixed that broken logic in elastic#1112, which finally uncovered this issue. With this commit we ensure now that administrative tasks are always executed regardless whether the user excludes them. We also increase test coverage in this part of the code.
danielmitterdorfer
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user specified
--exclude-tasks, Rally did not only exclude thespecified tasks but also all administrative tasks. This happened because
of a broken logic that always added an admin task filter internally. Due
to another bug, administrative tasks where never correctly detected but
we fixed that broken logic in #1112, which finally uncovered this issue.
With this commit we ensure now that administrative tasks are always
executed regardless whether the user excludes them. We also increase
test coverage in this part of the code.