Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for merge_count and merge_time graphs #1211

Merged
merged 4 commits into from
Mar 23, 2021
Merged

Add support for merge_count and merge_time graphs #1211

merged 4 commits into from
Mar 23, 2021

Conversation

ebadyano
Copy link
Contributor

No description provided.

@ebadyano ebadyano added the :misc Changes that don't affect users directly: linter fixes, test improvements, etc. label Mar 15, 2021
@ebadyano ebadyano self-assigned this Mar 15, 2021
danielmitterdorfer
danielmitterdorfer reviewed Mar 18, 2021
View reviewed changes
Copy link
Member

@danielmitterdorfer danielmitterdorfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly fine; I left some minor comments.

esrally/chart_generator.py Outdated Show resolved Hide resolved
esrally/chart_generator.py Outdated Show resolved Hide resolved
esrally/chart_generator.py Outdated Show resolved Hide resolved
esrally/chart_generator.py Outdated Show resolved Hide resolved
@danielmitterdorfer danielmitterdorfer added this to the 2.1.0 milestone Mar 18, 2021
@danielmitterdorfer danielmitterdorfer added the enhancement Improves the status quo label Mar 18, 2021
danielmitterdorfer
danielmitterdorfer approved these changes Mar 23, 2021
View reviewed changes
Copy link
Member

@danielmitterdorfer danielmitterdorfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@ebadyano ebadyano merged commit f1ade1c into elastic:master Mar 23, 2021
@ebadyano ebadyano added :internal Changes for internal, undocumented features: e.g. experimental, release scripts and removed :misc Changes that don't affect users directly: linter fixes, test improvements, etc. labels Jun 7, 2021
@ebadyano ebadyano deleted the merge-chart branch December 16, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielmitterdorfer danielmitterdorfer danielmitterdorfer approved these changes

@dliappis dliappis Awaiting requested review from dliappis

Assignees

@ebadyano ebadyano

Labels
enhancement Improves the status quo :internal Changes for internal, undocumented features: e.g. experimental, release scripts
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ebadyano @danielmitterdorfer