-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix make lint
on Python 3.10
#1565
Conversation
In practice this means upgrading pylint which was failing on 3.9 and 3.10.
The Do you want to disable this for now? |
For now I'm more concerned by the fact that I'm not seeing those errors locally! Do you see them when running |
I also don't see the above mentioned errors when I run this PR locally with a clean venv using Kind of unrelated,
|
I ended up just disabling that check like I've done in esbench as it's of low value anyway. |
Thanks! I opened #1567 to address this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
In practice this means upgrading pylint which was failing on 3.9 and 3.10.
I would like to use Python 3.10 as my daily driver to avoid discovering issues like #1484 only through our users, but I could not run
make lint
on Python 3.10 which made this impractical.