Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archive Rally logs in rally-tracks-compat job #1696

Merged
merged 3 commits into from
Apr 3, 2023

Conversation

pquentin
Copy link
Member

This was needed to investigate #1688.

@pquentin pquentin added tech debt :ci Everything related to CI labels Mar 28, 2023
@pquentin pquentin added this to the 2.8.0 milestone Mar 28, 2023
@pquentin pquentin self-assigned this Mar 28, 2023
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@dliappis
Copy link
Contributor

@pquentin Where can we find the uploaded logs from GH actions? Some sort of pointer would be beneficial (even as a comment there)

@pquentin
Copy link
Member Author

The artifact shows up under "Artifacts" in the "Summary" page: https://github.com/elastic/rally/actions/runs/4543523055?pr=1696 (which is counterintuitive, I would have expected to see it in the build itself)

image

@@ -67,6 +67,12 @@ jobs:
# elastic/endpoint fetches assets from GitHub, authenticate to avoid
# being rate limited
ASSETS_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- uses: actions/upload-artifact@v3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add a comment here to help us remember where to find the artifact in the future?

Per your comment

The artifact shows up under "Artifacts" in the "Summary" page: https://github.com/elastic/rally/actions/runs/4543523055?pr=1696 (which is counterintuitive, I would have expected to see it in the build itself)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 26fb761 (#1696)

@dliappis
Copy link
Contributor

LGTM also after the latest commit. Thanks for adding the comment.

Copy link
Member

@danielmitterdorfer danielmitterdorfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very useful. Thanks!

@pquentin pquentin merged commit ea01989 into elastic:master Apr 3, 2023
@pquentin pquentin deleted the rally-logs branch April 3, 2023 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:ci Everything related to CI tech debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants