-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Archive Rally logs in rally-tracks-compat job #1696
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
@pquentin Where can we find the uploaded logs from GH actions? Some sort of pointer would be beneficial (even as a comment there) |
The artifact shows up under "Artifacts" in the "Summary" page: https://github.com/elastic/rally/actions/runs/4543523055?pr=1696 (which is counterintuitive, I would have expected to see it in the build itself) |
@@ -67,6 +67,12 @@ jobs: | |||
# elastic/endpoint fetches assets from GitHub, authenticate to avoid | |||
# being rate limited | |||
ASSETS_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | |||
- uses: actions/upload-artifact@v3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add a comment here to help us remember where to find the artifact in the future?
Per your comment
The artifact shows up under "Artifacts" in the "Summary" page: https://github.com/elastic/rally/actions/runs/4543523055?pr=1696 (which is counterintuitive, I would have expected to see it in the build itself)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 26fb761
(#1696)
LGTM also after the latest commit. Thanks for adding the comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very useful. Thanks!
This was needed to investigate #1688.