Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow specifying branch together with timestamp in revision #1706

Merged
merged 2 commits into from
Apr 25, 2023
Merged

Allow specifying branch together with timestamp in revision #1706

merged 2 commits into from
Apr 25, 2023

Conversation

dliappis
Copy link
Contributor

@dliappis dliappis commented Apr 20, 2023 •
edited
Loading

With this commit, we add support for an optional branch when a timestamp is specified in --revision. This is intended primarily for Elasticsearch nightly benchmarks.

@dliappis
Allow specifying branch together with timestamp in revision
a79c1f1 
With this commit, we add support for an optional branch when a
timestamp is specified in --revision. This is intended primarily for
Elasticsearch nightly benchmarks.
@dliappis dliappis added enhancement Improves the status quo :Benchmark Candidate Management Anything affecting how Rally sets up Elasticsearch labels Apr 20, 2023
@dliappis dliappis self-assigned this Apr 20, 2023
@dliappis dliappis requested a review from csoulios April 20, 2023 12:54
@dliappis
Copy link
Contributor Author

Example invocations:

esrally build --revision=feature-branch@2023-04-19T18:00:00Z

esrally race --track=nyc_taxis --challenge=append-no-conflicts-index-only --revision="8.7@2023-04-19T18:00:00Z" --track-params="ingest_percentage:5" --car=defaults,16gheap --on-error=abort --kill-running-processes

@dliappis dliappis removed the request for review from pquentin April 21, 2023 11:44
@dliappis dliappis merged commit be05b65 into elastic:master Apr 25, 2023
@dliappis dliappis added this to the 2.8.0 milestone Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b-deam b-deam b-deam approved these changes

@csoulios csoulios Awaiting requested review from csoulios

Assignees

@dliappis dliappis

Labels
:Benchmark Candidate Management Anything affecting how Rally sets up Elasticsearch enhancement Improves the status quo
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dliappis @b-deam