Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run all tests on release #1733

Merged
merged 5 commits into from
Jun 21, 2023
Merged

Run all tests on release #1733

merged 5 commits into from
Jun 21, 2023

Conversation

pquentin
Copy link
Member

@gbanasiak noticed while releasing Rally that we were only running simple unit tests. This pull request fixes the issue.

@pquentin pquentin added bug Something's wrong :internal Changes for internal, undocumented features: e.g. experimental, release scripts labels Jun 12, 2023
@pquentin pquentin self-assigned this Jun 12, 2023
@pquentin
Copy link
Member Author

@elastic/es-perf Is anyone here using make test for development? I'm using pytest directly, so the change to make test does not affect me, but maybe it affects you?

gbanasiak
gbanasiak approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@gbanasiak gbanasiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dliappis
dliappis reviewed Jun 12, 2023
View reviewed changes
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections to this change. Makes sense.
Left one question.

Makefile Outdated Show resolved Hide resolved
@dliappis dliappis self-requested a review June 20, 2023 08:28
dliappis
dliappis approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pquentin
Copy link
Member Author

buildkite build this please

@pquentin pquentin merged commit 7c8f6c7 into elastic:master Jun 21, 2023
11 checks passed
@pquentin pquentin deleted the make-it branch June 21, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dliappis dliappis dliappis approved these changes

@gbanasiak gbanasiak gbanasiak approved these changes

Assignees

@pquentin pquentin

Labels
bug Something's wrong :internal Changes for internal, undocumented features: e.g. experimental, release scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pquentin @dliappis @gbanasiak