Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to JDK 21 #1875

Merged
merged 3 commits into from
Sep 13, 2024
Merged

Switch to JDK 21 #1875

merged 3 commits into from
Sep 13, 2024

Conversation

gareth-ellis
Copy link
Member

This updates the build JDK to 21, since Elasticsearch@main now requires 21 to build. I bumped the github action versions too at the same time

@gareth-ellis gareth-ellis requested a review from a team September 12, 2024 12:22
ebadyano
ebadyano approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@ebadyano ebadyano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you

@ebadyano
Copy link
Contributor

juts noticed the errors in the build:



s = '[ERROR] Cannot build. Neither JAVA21_HOME nor JAVA_HOME point to a JDK 21 installation.', cls = None, object_hook = None, parse_float = None
  | parse_int = None, parse_constant = None, object_pairs_hook = None, kw = {}
 

<br class="Apple-interchange-newline">

@ebadyano
Copy link
Contributor

Unrelated but do we also need to update something here:
https://github.com/elastic/rally/blob/5dc558f8741e483e853ca2131ad374f610b0bad1/.buildkite/it/run.sh#L35?

@ebadyano ebadyano self-requested a review September 12, 2024 13:58
@gareth-ellis gareth-ellis requested a review from a team September 12, 2024 17:45
@gareth-ellis
Copy link
Member Author

Just serverless thats waiting, but that test isnt touched by this PR

@gareth-ellis gareth-ellis merged commit c195f2c into master Sep 13, 2024
30 checks passed
@gareth-ellis gareth-ellis deleted the use-jdk-21-for-build branch September 13, 2024 09:37
@favilo favilo added this to the 2.11.1 milestone Nov 6, 2024
@favilo favilo added :misc Changes that don't affect users directly: linter fixes, test improvements, etc. highlight A substantial improvement that is worth mentioning separately in release notes and removed :misc Changes that don't affect users directly: linter fixes, test improvements, etc. labels Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbanasiak gbanasiak gbanasiak approved these changes

@ebadyano ebadyano Awaiting requested review from ebadyano

Assignees
No one assigned
Labels
highlight A substantial improvement that is worth mentioning separately in release notes
Projects
None yet
Milestone
2.11.1
Development

Successfully merging this pull request may close these issues.
4 participants
@gareth-ellis @ebadyano @gbanasiak @favilo