Allow to benchmark Elasticsearch with and without x-pack #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielmitterdorfer
added
enhancement
dliappis
approved these changes
Apr 27, 2018
esrally/mechanic/supplier.py
Outdated
| try: | ||
| return self.car.variables[k] | ||
| except KeyError: | ||
| raise exceptions.SystemSetupError("Car '{}' misses config variable '{}' to build Elasticsearch.".format(self.car, k)) |
There was a problem hiding this comment.
maybe is missing is clearer here
There was a problem hiding this comment.
Agreed. I changed it.
| logger.debug("Component [%s] in config [%s] has no hook registered for phase [%s].", | ||
| self.component.name, self.component.config, phase) |
There was a problem hiding this comment.
Newline missing as pointed by GitHub
| # this should *always* be overridden by the car definition (config base | ||
| # variables take least precedence) | ||
| heap_size=0 | ||
| clean_command=./gradlew clean |
There was a problem hiding this comment.
Same newline missing comment
| @@ -0,0 +1,2 @@ | |||
| [variables] | |||
| verbose_logging=true | |||
There was a problem hiding this comment.
Same newline missing comment
| logger.debug("Component [%s] in config [%s] has no hook registered for phase [%s].", | ||
| self.component.name, self.component.config, phase) |
With this commit we replace all usages of `assert_not_called` with asserts that assert for a zero call_count. The reason is that `assert_not_called` has only beeen introduced in Python 3.5 but we also support (and test) Python 3.4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
x-pack, which has been previously implemented as a (closed-source) plugin, has
been recently opened. During that process, x-pack turned from a plugin into a
core module of Elasticsearch. Furthermore, there are now two distributions:
This has several implications on our benchmarks as well. With this commit we
implement the following changes:
plugin anymore). Strictly speaking, this change has happened in rally-teams
because Rally does not know about individual plugins.
(previously this was only possible for plugins). One restriction is that we only
allow to load one bootstrap handler.