Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get distribution download URL from car config #489

Merged
merged 2 commits into from
May 3, 2018

Conversation

danielmitterdorfer
Copy link
Member

With this commit we read the download URL for an Elasticsearch
distribution from the car (and similarly for plugins). This is necessary
because with Elasticsearch 6.3 there will be two Elasticsearch
distributions: A pure OSS one and one that includes x-pack. Handling
this in rally.ini would have been possible but it is cleaner leveraging
our team repository infrastructure for this task.

With this commit we read the download URL for an Elasticsearch
distribution from the car (and similarly for plugins). This is necessary
because with Elasticsearch 6.3 there will be two Elasticsearch
distributions: A pure OSS one and one that includes x-pack. Handling
this in rally.ini would have been possible but it is cleaner leveraging
our team repository infrastructure for this task.
@danielmitterdorfer danielmitterdorfer added enhancement Improves the status quo :Benchmark Candidate Management Anything affecting how Rally sets up Elasticsearch labels May 2, 2018
@danielmitterdorfer danielmitterdorfer added this to the 0.11.0 milestone May 2, 2018
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, makes sense to move the properties to the rally-teams repo.

However, isn't there a need to document this change, at least in the migration guide, for users who maintain their own custom team repositories?

@danielmitterdorfer
Copy link
Member Author

I have now documented config.ini in 8928de3. Can you please have another look @dliappis?

@dliappis
Copy link
Contributor

dliappis commented May 3, 2018

@danielmitterdorfer Thanks for adding the documentation in. LGTM.

@danielmitterdorfer danielmitterdorfer merged commit 573dac7 into elastic:master May 3, 2018
@danielmitterdorfer danielmitterdorfer deleted the car_dist branch May 3, 2018 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Benchmark Candidate Management Anything affecting how Rally sets up Elasticsearch enhancement Improves the status quo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants