Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Rally compatible with Python 3.7 #563

Merged
merged 2 commits into from
Sep 17, 2018

Conversation

danielmitterdorfer
Copy link
Member

With this commit we make Rally compatible with Python 3.7. The main
change is due to PEP 479.
Apart from that we do a couple of smaller cleanups and document it in
our setup file.

With this commit we make Rally compatible with Python 3.7. The main
change is due to [PEP 479](https://www.python.org/dev/peps/pep-0479/).
Apart from that we do a couple of smaller cleanups and document it in
our setup file.
@danielmitterdorfer danielmitterdorfer added enhancement Improves the status quo :misc Changes that don't affect users directly: linter fixes, test improvements, etc. labels Sep 3, 2018
@danielmitterdorfer danielmitterdorfer added this to the 1.0.2 milestone Sep 3, 2018
@danielmitterdorfer
Copy link
Member Author

I suggest we target this change for release 1.0.2 instead of 1.0.1.

Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM left a minor comment.

.gitignore Outdated
@@ -106,7 +106,7 @@ target/
# Rally specific
.rally_it/
# Virtualenv for development
.venv/
.venv*/

# Emacs backup files
*~
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: no newline here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@danielmitterdorfer danielmitterdorfer merged commit e33246f into elastic:master Sep 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves the status quo :misc Changes that don't affect users directly: linter fixes, test improvements, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants