Add shrink index runner #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we add a new runner to Rally that executes the shrink index API and all other relevant API calls in order to shrink an index.
danielmitterdorfer
added
enhancement
|
If you want to try this at home: I've used a modified version of the geonames track for my tests. |
dliappis
approved these changes
Sep 10, 2018
There was a problem hiding this comment.
Excellent work as usual! LGTM.
I also tried executing it manually using the mentioned custom shrink-geonames track, which worked fine.
| source_index = mandatory(params, "source-index", self) | ||
| target_index = mandatory(params, "target-index", self) | ||
| # we need to inject additional settings so we better copy the body | ||
| target_body = deepcopy(mandatory(params, "target-body", self)) |
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we add a new runner to Rally that executes the shrink
index API and all other relevant API calls in order to shrink an index.