-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add recovery-stats telemetry device #639
Add recovery-stats telemetry device #639
Conversation
With this commit we add a new telemetry device called `recovery-stats` which can be used to retrieve statistics about ongoing recoveries while running a benchmark. Closes elastic#635
I've tested the changes with the attached test-track. That track restores an index Test scenarios (all with an ES metrics store):
{
"recovery-stats-indices": {
"default": "taxi*"
},
"recovery-stats-sample-interval": 2
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks! I left a small note for the docs.
docs/telemetry.rst
Outdated
jfr Flight Recorder Enables Java Flight Recorder (requires an Oracle JDK) | ||
perf perf stat Reads CPU PMU counters (requires Linux and perf) | ||
node-stats Node Stats Regularly samples node stats | ||
Command Name Description |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This table seems to be indented by +1 character to the right hence not aligned with the title. Is it on purpose?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. IIRC I just pressed tab
and assumed it did the right thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've addressed this in b61b64e
@@ -102,6 +102,8 @@ def all_options(self): | |||
|
|||
|
|||
class TargetHosts(ConnectOptions): | |||
DEFAULT = "default" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 thanks for this.
I've tested this also with the in-memory metrics store and although this telemetry device is not useful there (it only writes raw metrics entries which get lost if the metrics store is transient), it should at least not break it. This is addressed in db94883. @dliappis can you please have another look at those changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it with both internal and external metric store. Works great, thanks!
LGTM
Thanks! Merged. |
With this commit we add a new telemetry device called
recovery-stats
which can be used to retrieve statistics about ongoing recoveries while
running a benchmark.
Closes #635