Fail Rally early if there are unused variables in track-params #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is fully working, but doesn't address variables in track / body / index_template in a uniform way.
This WiP is fully working and catches cases when a track-param overrides only index settings or index templates.
and add new integration tests and unit tests. Also clean up debug statements.
|
@danielmitterdorfer I am open to suggestions as to the milestone, perhaps |
dliappis
changed the title
|
I tested the workflow in vagrant, including the changes to address PR comments and suggestions for the correct parameters, and our nightlies seem to ok. I've requested another review pass. |
|
@danielmitterdorfer can you take another pass please? I addressed the refactoring requests and other comments. |
danielmitterdorfer
added
the
:Track Management
danielmitterdorfer
approved these changes
May 23, 2019
danielmitterdorfer
added
the
highlight
and add a test case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment we are not checking if user-defined parameters in
--track-paramsactuallydo end up getting applied in any of the referenced jinja2 templates in the track, index body or referenced index templates. This can be very dangerous e.g. when trying to influence crucial benchmarking parameters that are parametrizable in our standard tracks, like
number_of_shards,source_enabledetc.Fail Rally fast if unused parameters get supplied with
--track-params.Resolves #478