Provide default for datastore.secure in all cases #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we choose `False` as default value for the configuration property `datastore.secure` even when an in-memory metrics store is used. Contrary to the previous default (`""` (empty string)), this avoids errors when the user manually changes their configuration file to use an Elasticsearch metrics store but only provides host and port.
danielmitterdorfer
added
enhancement
|
Thanks for the review! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we choose
Falseas default value for theconfiguration property
datastore.secureeven when an in-memory metricsstore is used. Contrary to the previous default (
""(empty string)),this avoids errors when the user manually changes their configuration
file to use an Elasticsearch metrics store but only provides host and
port.