Register pyenv Python versions #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we ensure that make file targets work with all supported Python versions by registering them in a project-specific file that `pyenv` will read during the build.
danielmitterdorfer
added
bug
dliappis
requested changes
Jun 7, 2019
Makefile
Outdated
| @@ -36,6 +36,8 @@ prereq: make-requirements.txt | |||
| pyenv install --skip-existing $(PY37) | |||
| # pyenv global system $(PY34) $(PY35) $(PY36) $(PY37) | |||
| pyenv global system $(PY35) $(PY36) $(PY37) | |||
| @# Ensure all Python versions are registered for this project | |||
| @eval "$$(pyenv init -)" && pyenv versions --bare > .python-version; | |||
There was a problem hiding this comment.
As discussed makes sense to just use the already present make-requirements.txt with something like awk -F'=' '{print $2}' make-requirements.txt >.python-version
dliappis
approved these changes
Jun 7, 2019
Makefile
Outdated
| @@ -37,7 +37,7 @@ prereq: make-requirements.txt | |||
| # pyenv global system $(PY34) $(PY35) $(PY36) $(PY37) | |||
| pyenv global system $(PY35) $(PY36) $(PY37) | |||
| @# Ensure all Python versions are registered for this project | |||
| @eval "$$(pyenv init -)" && pyenv versions --bare > .python-version; | |||
| @awk -F'=' '{print $$2 > ".python-version"}' make-requirements.txt | |||
There was a problem hiding this comment.
This works, but IMHO it is a bit strange to do a file redirection inside awk for this use case;
would it be simpler to
@awk -F'=' '{print $$2}' make-requirements.txt >.python-version
i.e. redirect the final result of awk to .python-version?
There was a problem hiding this comment.
I've changed it now.
!
|
Thanks for the review! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we ensure that make file targets work with all
supported Python versions by registering them in a project-specific file
that
pyenvwill read during the build.