Store track-related meta-data in results #771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rally allows to specify meta-data on track, challenge, task and operation level. This information is stored for raw metrics records but not for results. With this commit we ensure that any meta-data are properly set also on the respective results documents. This allows to use this information also e.g. in Kibana visualizations.
danielmitterdorfer
added
enhancement
dliappis
approved these changes
Sep 12, 2019
| @@ -327,23 +340,32 @@ def as_dict(self): | |||
| return self.__dict__ | |||
|
|
|||
| def as_flat_list(self): | |||
| def op_metrics(op_item, key, single_value=False): | |||
|
Thanks for the review! :) |
novosibman
pushed a commit
to novosibman/rally
that referenced
this pull request
Oct 2, 2019
Rally allows to specify meta-data on track, challenge, task and operation level. This information is stored for raw metrics records but not for results. With this commit we ensure that any meta-data are properly set also on the respective results documents. This allows to use this information also e.g. in Kibana visualizations. Relates elastic#771
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rally allows to specify meta-data on track, challenge, task and
operation level. This information is stored for raw metrics records but
not for results. With this commit we ensure that any meta-data are
properly set also on the respective results documents. This allows to
use this information also e.g. in Kibana visualizations.