-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix port number in recipes docs #937
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The intention behind using port 9200
for the examples was that people are familiar with that port. Also, from what I could see the examples seem to be consistent right now? Is there any reason to switch to port 39200
instead?
@dliappis had asked me to do this because of some errors he had with a discuss issue. I think he would be best to comment on this. |
There are a number of motivations for switching to
I've noticed that both can lead to confusion for users, especially when using esrallyd. Alternatively, I think we could document in --target-hosts that Rally will automatically derive and use the port defined there as the Elasticsearch http_port (and based on that transport_port+100) |
I don't think we should do that given that we are about to move to the new subcommands where the port needs to be specified explicitly.
I'd argue that when users use |
Yeah we are in this in-between state currently; people find and still use the daemon mode and hit issues, so this was the main motivation here esp. since this magic handling of the port isn't currently documented.
Fair point; I'd counter argue that e.g. in Elastic Cloud this isn't the out of the box default either, but for self managed clusters one would think in most cases the port is 9200. |
had an offline chat with @danielmitterdorfer re ^^ @hub-cap let's amend this PR to only change The Distributing the load test driver example assumes an externally provisioned cluster (so that's ok, no changes needed there) and the first example, Benchmarking an existing cluster is also about externally provisioned clusters, so no changes needed there either. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM
No description provided.