Fix fallback implementation of ML-related runners #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we fix several issues of the fallback implementation of ML-related runners. This implementation is only used for older versions of Elasticsearch which still include the `_xpack` path component and use the raw transport API of the Elasticsearch client. However, especially the handling of request parameters did not conform to the API requirements. Relates elastic#812
danielmitterdorfer
added
bug
|
Note to reviewers (@hub-cap): This should be tested together with elastic/rally-tracks#111. One way to test this (which has failed so far on |
|
I did not get around to testing this today, I will tomorrow though unless @dliappis beats me to it :) |
hub-cap
approved these changes
Apr 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we fix several issues of the fallback implementation of
ML-related runners. This implementation is only used for older versions
of Elasticsearch which still include the
_xpackpath component and usethe raw transport API of the Elasticsearch client. However, especially
the handling of request parameters did not conform to the API
requirements.
Relates #812