Raise an error when attempting to bulk-index without any corpora #967
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to solve the issue #568.
As discussed in the issue, now the
BulkIndexParamSource
constructor checks whether thatself.corpora
is empty and if it is raiseexceptions.InvalidSyntax
.Summary of changes:
Explicit error is raised when list of corpora is empty and you try to bulk requests to Elasticsearch.
Output example when running a Rally race without corpora definition.
Fix tests that started to fail after the new error check.
Add new test for this new error check.
I hope this helps :)