Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure artifact cache directory exists #996

Merged
merged 1 commit into from
May 13, 2020
Merged

Ensure artifact cache directory exists #996

merged 1 commit into from
May 13, 2020

Conversation

danielmitterdorfer
Copy link
Member

With this commit we create the artifact cache directory if it does not
exist yet. Otherwise, the artifact cannot be cached making the cache
ineffective.

Relates #992

@danielmitterdorfer
Ensure artifact cache directory exists
2d2c94e 
With this commit we create the artifact cache directory if it does not
exist yet. Otherwise, the artifact cannot be cached making the cache
ineffective.

Relates elastic#992
@danielmitterdorfer danielmitterdorfer added bug Something's wrong :Benchmark Candidate Management Anything affecting how Rally sets up Elasticsearch labels May 13, 2020
@danielmitterdorfer danielmitterdorfer added this to the 2.0.1 milestone May 13, 2020
@danielmitterdorfer danielmitterdorfer self-assigned this May 13, 2020
dliappis
dliappis approved these changes May 13, 2020
View reviewed changes
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielmitterdorfer danielmitterdorfer merged commit dba7786 into elastic:master May 13, 2020
@danielmitterdorfer danielmitterdorfer deleted the ensure-cache-dir branch May 13, 2020 08:28
@danielmitterdorfer
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dliappis dliappis dliappis approved these changes

Assignees

@danielmitterdorfer danielmitterdorfer

Labels
:Benchmark Candidate Management Anything affecting how Rally sets up Elasticsearch bug Something's wrong
Projects
None yet
Milestone
2.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@danielmitterdorfer @dliappis