Test improvements #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinkambic
reviewed
Sep 9, 2020
|
|
||
| export const cliArgs = program; | ||
| export const parseArgs = () => { |
There was a problem hiding this comment.
I had considered doing this when I wrote this code; the reason I elected to not use a function because in the case where the code runs from cli.ts, this parse will run twice, once again from inside the main run function.
It's probably not a big deal, but I wanted to avoid the redundancy. Thoughts?
There was a problem hiding this comment.
I'm not worried about perf here, it's very fast
| } | ||
| `); | ||
| it('uses undefined options when none specified', async () => { | ||
| await run({ params: {}, environment: 'debug' }); |
There was a problem hiding this comment.
👍 I should've realized await was missing when I wrote the tests.
justinkambic
approved these changes
Sep 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
parse_argsmodule to be more mockableIn other needs we really need to get CI up and running to fix these issues