Add external-secrets support #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldada
requested changes
Apr 6, 2021
| {{- if .Values.useExistingSecret }} | ||
| name: {{ .Values.existingSecretName }} | ||
| {{- else }} | ||
| name: {{ template "postfix.fullname" . }} |
There was a problem hiding this comment.
Should be name: {{ template "postfix.fullname" . }}-secret?
helm/postfix/values.yaml
Outdated
| existingSecretName: postfix | ||
|
|
||
| # e.g kuberentes-external-secrets | ||
| useExternalSecrets: false |
There was a problem hiding this comment.
Can we put this under a dedicated block like the following
externalSecret:
enabled: false
secretsBackendType: secretsManager
secretsKey: infra/postfix
README.md
Outdated
| helm/postfix | ||
| ``` | ||
|
|
||
| 1. Use kubernetes external secrets |
There was a problem hiding this comment.
Can you add a link to the ExternalSecret resource type?
There was a problem hiding this comment.
it's there a few linws above - added link to CRD.yml
eldada
reviewed
Apr 7, 2021
| --set smtp.relayMyhostname=my.local \ | ||
| --set smtp.relayUsername=${USERNAME} \ | ||
| --set useExternalSecrets=true \ | ||
| --set ExternalSecretsBackendType=secretsManager \ |
There was a problem hiding this comment.
Need to update the example post your refactoring...
There was a problem hiding this comment.
Please fix this so I can merge. Looks like this is the last issue @hagzag .
eldada
requested changes
Apr 7, 2021
|
@hagzag ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@eldada looked useful ;) - added some support for secrets.