Use UMD. Now works in CommonJS when window.$ is undefined #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paltman
added a commit
that referenced
this pull request
Apr 8, 2015
Use UMD. Now works in CommonJS when window.$ is undefined
|
Thanks! |
|
Awesome :) how long will it be until this is in a release? |
|
@paltman Hey, any update on releasing this? Could really use it, it's the last thing stopping me from getting rid of my |
|
@callumacrae I just published 0.13.0. It's not showing up on npmjs.org yet, but I assume that is just some caching. |
|
It's showing for me. Thanks! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
window.$is undefined because I'm using Browserify to load everything, and setting it is hacky. This fix adds UMD to this project 😄