Fix localization failure for pre-release (microsoft#22639)

Fixes pre-release, dynamic strings are not supported by localization.
eleanorjboyd · Dec 13, 2023 · 1c37df5 · 1c37df5
1 parent d275aac
commit 1c37df5
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/src/client/logging/settingLogs.ts b/src/client/logging/settingLogs.ts
@@ -99,7 +99,8 @@ async function notifyLegacySettings(): Promise<void> {
     _isShown = true;
     const response = await showWarningMessage(
         l10n.t(
-            `You have deprecated linting or formatting settings for Python. Please see the [logs](command:${Commands.ViewOutput}) for more details.`,
+            'You have deprecated linting or formatting settings for Python. Please see the [logs](command:{0}) for more details.',
+            Commands.ViewOutput,
         ),
         Common.learnMore,
     );

diff --git a/src/client/pythonEnvironments/creation/common/installCheckUtils.ts b/src/client/pythonEnvironments/creation/common/installCheckUtils.ts
@@ -27,7 +27,7 @@ function parseDiagnostics(data: string): Diagnostic[] {
         diagnostics = raw.map((item) => {
             const d = new Diagnostic(
                 new Range(item.line, item.character, item.endLine, item.endCharacter),
-                l10n.t(`Package \`${item.package}\` is not installed in the selected environment.`),
+                l10n.t('Package `{0}` is not installed in the selected environment.', item.package),
                 item.severity,
             );
             d.code = { value: item.code, target: Uri.parse(`https://pypi.org/p/${item.package}`) };

diff --git a/src/test/terminals/codeExecution/smartSend.test.ts b/src/test/terminals/codeExecution/smartSend.test.ts
@@ -302,7 +302,8 @@ suite('REPL - Smart Send', () => {
                     l10n.t(
                         `Python is unable to parse the code provided. Please
                 turn off Smart Send if you wish to always run line by line or explicitly select code
-                to force run. [logs](command:${Commands.ViewOutput}) for more details.`,
+                to force run. [logs](command:{0}) for more details.`,
+                        Commands.ViewOutput,
                     ),
                     'Switch to line-by-line',
                 ),