Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: where clause limitations with feature request CTA. #1773

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

thruflo
Copy link
Contributor

@thruflo thruflo commented Oct 1, 2024

Partly addresses #1769 although it would be much better to add more technical details.

https://deploy-preview-1773--electric-next.netlify.app/docs/guides/shapes#where-clause

@thruflo thruflo requested a review from alco October 1, 2024 00:46
Copy link

netlify bot commented Oct 1, 2024

Deploy Preview for electric-next ready!

Name Link
🔨 Latest commit 0e39056
🔍 Latest deploy log https://app.netlify.com/sites/electric-next/deploys/66fe948c475eb800089dac4e
😎 Deploy Preview https://deploy-preview-1773--electric-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alco
Copy link
Member

alco commented Oct 3, 2024

@thruflo given the small subset of SQL we support in shape where clauses, I believe it is more helpful to talk about what is supported, first and foremost. I have pushed a commit to that effect to your branch.

Copy link
Contributor

@KyleAMathews KyleAMathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@KyleAMathews KyleAMathews merged commit 6607089 into main Oct 8, 2024
22 of 23 checks passed
@KyleAMathews KyleAMathews deleted the thruflo/document-where-clause-limitations branch October 8, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants