This repository has been archived by the owner on Feb 1, 2023. It is now read-only.
Remove pyproject causing pip install issues #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On non pep517 ready systems having the pyproject will fail... As Black only allows for using the pyproject file the best option seems to duplicate the config... Another option is to force users to install with the "--no-use-pep517"
madsnedergaard
approved these changes
Sep 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some system the pip install step will fail if we have the pyproject.toml file (currently only used for configuring Black)... There is more context here:
As Black only supports using pyproject for configuration, the best option seems to be duplicating the config and provide it as CLI arguments.
Another option is to force users to install with the "--no-use-pep517" (which also works, but isn't as nice for the end user).