Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for MySQL storage #31

Merged
merged 15 commits into from
Jan 8, 2018
Merged

Conversation

datvong-wm
Copy link
Contributor

Add support for MySQL/MariaDB as the data store.

Copy link
Member

@jchip jchip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review so far, will continue later.

{
"name": "electrode-ota-server-dao-factory",
"version": "3.0.0",
"description": "OTA DAO",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add author, repository, license, bugs


const nullUnlessValue = (obj, keys) => {
for (const key of keys) {
if (obj[key] === void(0)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you want to null properties that do not exist also?

don't like undefined?

I think objDefaultNull is slightly more telling.

@@ -0,0 +1,7 @@
# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't make your mind about yarn or npm? :)

@@ -0,0 +1,23 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add author, license, repository

import _ from 'lodash';
import {Sequelize} from 'sequelize';
import {ProxyModelWrapper} from './proxy';
import cls from 'continuation-local-storage';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This. Will. Be. Your. Worst. Nightmare.

othiym23/node-continuation-local-storage#59

Copy link
Member

@jchip jchip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should setup eslint

@datvong-wm datvong-wm merged commit 541b831 into electrode-io:master Jan 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants