-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build AppImage for Linux #504
Comments
oh shit, thats cool, subscribed :-) |
Sorry for dumb question, but quick search doesn't help — electron app requires libnotify and libappindicator packages — is this problem solved in the AppImage? |
Yes. Simply bundle them inside the AppImage. Please open an issue on probonopd/AppImages if the AppImage linked above doesn't work on one of your targeted distributions. |
Ok, got it. Cool thing that electron-builder already provides tested and functional docker images, so, first condition "Use an old system for building (at least 2-3 years old) to ensure the binaries run on older systems too" is already done. |
Sadly, that fpm doesn't support AppImage and even there is no issue. |
@develar Now there is: jordansissel/fpm#1133 |
http://www.etcher.io/ is using AppImage as their main format for distributing the Linux version of an Electron-based app. Here is their code that produces the AppImage: |
@develar cool. Let me know if you run into any kind of issues you need help with. |
It means you will not be supporting deb and rpm any more in the future? There's some downsides to appimage too, namely it including old system binaries (I think). Will the appimageautoupdate work with electron as well? There's other tools as well, gnome flatpak, and ubuntu snappy apps that you may want to look at. |
@kunkinkan We are open source project. I cannot in my free time test Linux Zoo and compute required packages for each format — #502 If you use opensuse&rpm — send PR or wait. i.e. — don't expect that RPM support will be polished if no-one will report issues.
As we are open source project, there is no any guarantee ;) Current priority chain — OS X -> Windows -> NSIS -> Squirrel -> deb -> rpm -> AppImage. |
Of course, it was just a question, not a demand or anything :-) Unfortunately I'm not competent enough to contribute much to this project, I'm afraid :-) But I am reporting issues ;-) |
Why #509 is closed as backlog but this Appimage will be supported this week — see AppImage/AppImageKit#166 |
macOS: https://github.com/electron-userland/electron-builder/wiki/Multi-Platform-Build#to-build-app-for-linux-on-macos ( linux: https://github.com/electron-userland/electron-builder/wiki/Multi-Platform-Build#linux ( windows: use https://github.com/electron-userland/electron-builder/wiki/Docker (docker images updated, but not yet fully tested). Thanks a lot @probonopd for amazing format. Please note — we pack AppImage into libnotify and auto update will be addressed in separate issues. |
Please add version tag so that we can try it :-) |
Current known "critical" cosmetic issue — icon in the Uniny dock shown only if run as app, not on click on image. AppImage/AppImageKit#174 |
@devalar , still no version tag, and "dev-master" doesn't seem to work either. How can test? |
If no
Yes, we use own version of desktopintegration and don't use AppRun — https://github.com/electron-userland/electron-builder/blob/master/templates/linux/AppRun.sh
We generate all — desktop file, executable. https://github.com/electron-userland/electron-builder/blob/master/src/targets/appImage.ts So, I am sure, it is app error, not our error (please note, that hipchat-electron uses outdated 3.x version, so, maybe something goes wrong). |
I tried
and an AppImage gets generated, but it wants to execute So could it be that this is not very robust? |
@probonopd Fixed, error was in bash script. |
AppImage is a default target for Linux since version 6 (will be released tomorrow). |
There should be a way for application authors to have fine-grained control over what ends up in the |
@probonopd Fixed.
e.g.:
|
IMHO, the AppImage should be saved in a tar file (just TAR without compression), then the executable flag will be preserved and the "unpack" is very fast. For an end-user it's easier... I know some Linux end-users where changing the permissions is not familiar at all. |
Now you can run AppImage produced by electron-builder on Elementary OS also. — #1082 (comment) |
Running into this here again, https://travis-ci.org/probonopd/readium-desktop#L2604 - using the latest Here is the |
@probonopd this project has "package" script. Instead of npm run build Just npm run package should be used |
AppImage is a format for portable, distribution-agnostic binary software deployment for Linux without needing root permissions or installation. (Wikipedia)
Here is an example for Atom in AppImage format:
https://bintray.com/probono/AppImages/Atom/_latestVersion#files
And here is the script which produced it:
https://github.com/probonopd/AppImages/blob/master/recipes/atom/Recipe
While it is relatively easy to package an Electron-based app as an AppImage, it would be nice if this could be automated in electron-builder.
The text was updated successfully, but these errors were encountered: