-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The build process will change the encoding of the license.rtf file. #8512
Comments
@TianbinTobin what OS are you packaging your Windows app on? @beyondkmp looks like this may be related to the changes in #8314. Wondering if we need to have conditional logic when building on windows vs mac w.r.t file encoding |
@mmaietta Windows 11 |
@mmaietta In #8294, I have only fixed the issue of garbled text display on Windows. The problem describing seems to be a different issue on Windows. @TianbinTobin Could you provide a minimal demo to reproduce the problem? |
https://github.com/TianbinTobin/electron-builder-8512.git The first build will change the encoding of the rtf file, and the second build of the installation package will appear garbled on windows. @beyondkmp |
@TianbinTobin I have a question: Why not write Chinese directly in this file? If Chinese is written directly, there wouldn't be any issues even with multiple compilations. |
Root Cause: If the file is already in UTF-8 BOM format, there's no need to convert it again. If it's converted again, it will result in garbled characters. |
…land#8551) fix electron-userland#8512 If the file is already in UTF-8 BOM format, there's no need to convert it again. If it's converted again, it will result in garbled characters. --------- Co-authored-by: beyondkmp <[email protected]>
The original encoding of my license.rtf file is UTF-8, but after the build process, the encoding has changed to UTF-8 with BOM.
This behavior will cause the License display on the installation interface to appear as garbled text.
(My language is Chinese.)
The text was updated successfully, but these errors were encountered: