fix: in Emit(), don't leak converted Arg Local<Values> into caller's scope
#43729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckerr
added
semver/patch
codebytere
changed the title
Emit(), don't leak converted Arg Local<Values> into caller's scope
codebytere
approved these changes
Sep 16, 2024
|
No Release Notes |
This was referenced Sep 17, 2024
|
I have automatically backported this PR to "33-x-y", please check out #43746 |
trop
bot
added
in-flight/33-x-y
and removed
target/33-x-y
|
I have automatically backported this PR to "32-x-y", please check out #43747 |
|
I have automatically backported this PR to "31-x-y", please check out #43748 |
|
I have automatically backported this PR to "30-x-y", please check out #43749 |
trop
bot
added
in-flight/32-x-y
in-flight/31-x-y
in-flight/30-x-y
and removed
target/32-x-y
3 tasks
trop
bot
added
merged/33-x-y
yangannyx
pushed a commit
to yangannyx/electron
that referenced
this pull request
Oct 21, 2024
…r's scope (electron#43729) fix: Emit() should not leak converted arg handles into caller's HandleScope
yangannyx
pushed a commit
to yangannyx/electron
that referenced
this pull request
Oct 21, 2024
…r's scope (electron#43729) fix: Emit() should not leak converted arg handles into caller's HandleScope
yangannyx
pushed a commit
to yangannyx/electron
that referenced
this pull request
Oct 21, 2024
…r's scope (electron#43729) fix: Emit() should not leak converted arg handles into caller's HandleScope
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The two
Emit(isolate, obj, name, Args&&... args)methods convertargsinto an array ofLocal<Value>sto pass to Node/V8. But they don't use a HandleScope, so these temporary handles are leaked into the caller's scopes.In most calls this is OK since either
argsis empty or since the caller creates a scope right before emission, but not everywhere. It's more reliable to handle this in theEmit()functions, so this PR addsEscapableHandleScopes to plug the leaks.Checklist
npm testpassesRelease Notes
Notes: none.