Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(publisher-s3): replace the s3 package with just aws-sdk #1318

Merged
merged 2 commits into from
Dec 3, 2019

Conversation

malept
Copy link
Member

@malept malept commented Dec 3, 2019

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

The s3 module appears to no longer be maintained, which means, among other things, outdated dependencies.

I made an attempt to write tests for this, but it appears that aws-sdk-mock has issues mocking S3.upload, so I abandoned it.

Fixes #479.

@codecov
Copy link

codecov bot commented Dec 3, 2019

Codecov Report

Merging #1318 into master will decrease coverage by 1.98%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1318      +/-   ##
==========================================
- Coverage   67.97%   65.98%   -1.99%     
==========================================
  Files          69       69              
  Lines        2011     2011              
  Branches      381      381              
==========================================
- Hits         1367     1327      -40     
- Misses        474      528      +54     
+ Partials      170      156      -14
Impacted Files Coverage Δ
packages/maker/wix/src/MakerWix.ts 42.85% <0%> (-42.86%) ⬇️
packages/maker/squirrel/src/MakerSquirrel.ts 31.57% <0%> (-42.11%) ⬇️
packages/maker/appx/src/MakerAppX.ts 19.29% <0%> (-33.34%) ⬇️
packages/maker/wix/src/util/author-name.ts 80% <0%> (-10%) ⬇️
packages/maker/appx/src/util/author-name.ts 80% <0%> (-10%) ⬇️
packages/api/core/src/util/electron-version.ts 88.23% <0%> (-7.85%) ⬇️
packages/maker/base/src/Maker.ts 68.57% <0%> (-2.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bcf036...f0d9b49. Read the comment docs.

@malept malept merged commit bbb0f90 into master Dec 3, 2019
@malept malept deleted the drop-s3 branch December 3, 2019 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[s3] publish fails with "callback called twice"
1 participant