chore(tests): add AppVeyor support #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malept
force-pushed
the
appveyor
branch
2 times, most recently
from
da47884
to
4236155
Compare
| @@ -0,0 +1,29 @@ | |||
| platform: | |||
| - x86 | |||
| - x64 | |||
There was a problem hiding this comment.
Couldn't we save build time / resources by simply adding a --arch=all test and only testing on x64 machines?
malept
force-pushed
the
appveyor
branch
2 times, most recently
from
da7d832
to
4dc6eee
Compare
MarshallOfSound
force-pushed
the
appveyor
branch
2 times, most recently
from
1b060d9
to
c0c24ae
Compare
MarshallOfSound
force-pushed
the
appveyor
branch
2 times, most recently
from
226ac8b
to
174df7f
Compare
MarshallOfSound
approved these changes
Dec 11, 2016
malept
commented
Sep 29, 2017
test/cli_spec.js
Outdated
| @@ -10,13 +10,15 @@ import { expect } from 'chai'; | |||
| import installDeps from '../src/util/install-dependencies'; | |||
|
|
|||
| const pSpawn = async (args = [], opts = { | |||
| stdio: 'inherit', | |||
| stdio: process.platform === 'win32' ? 'inherit' : 'pipe', | |||
There was a problem hiding this comment.
@MarshallOfSound do you remember why this is configured this way? I think it's causing electron-userland/electron-forge-templates#51
dsanders11
pushed a commit
that referenced
this pull request
Jan 14, 2023
Documentation, minor code cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have you read the section in CONTRIBUTING.md about pull requests?
Yes
Are your changes appropriately documented?
N/A
Do your changes have sufficient test coverage?
N/A
Does the testsuite pass successfully on your local machine?
N/A
Summarize your changes:
Adds AppVeyor (Windows) as a CI service.