Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): throw an error when no make targets for the given platform are found #1515

Merged
merged 2 commits into from
Feb 25, 2020

Conversation

malept
Copy link
Member

@malept malept commented Feb 25, 2020

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Currently, if there are no make targets for the given platform and make is run, it prints out:

Making for the following targets:

which is confusing. This PR notifies the user in the form of an exception that there are no make targets found.

Addresses #1514 (but unknown whether it fixes it at this time).

@malept malept changed the title fix(core): throw an error when no make targets for the given platform… fix(core): throw an error when no make targets for the given platform are found Feb 25, 2020
@codecov
Copy link

codecov bot commented Feb 25, 2020

Codecov Report

Merging #1515 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1515      +/-   ##
==========================================
+ Coverage   74.94%   74.96%   +0.02%     
==========================================
  Files          73       73              
  Lines        2119     2121       +2     
  Branches      398      399       +1     
==========================================
+ Hits         1588     1590       +2     
  Misses        407      407              
  Partials      124      124              

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f55a6c...78197ed. Read the comment docs.

@malept malept merged commit bc370aa into master Feb 25, 2020
@malept malept deleted the throw-error-when-no-make-targets-found branch February 25, 2020 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant