-
-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: refactor GitHub Action jobs #1875
Merged
malept
merged 14 commits into
electron:master
from
malept:malept/build/fast-slow-ci-jobs
Aug 1, 2020
Merged
build: refactor GitHub Action jobs #1875
malept
merged 14 commits into
electron:master
from
malept:malept/build/fast-slow-ci-jobs
Aug 1, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntegration tests better
Codecov Report
@@ Coverage Diff @@
## master #1875 +/- ##
==========================================
+ Coverage 70.28% 72.73% +2.44%
==========================================
Files 74 74
Lines 2191 2208 +17
Branches 414 415 +1
==========================================
+ Hits 1540 1606 +66
+ Misses 465 443 -22
+ Partials 186 159 -27
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize your changes:
Instead of splitting up tests by node installer, the tests are effectively split up by "integration" (i.e.,
api_spec_slow
in the core module) and "non-integration". The node installer specific tests are run in the same job, since bothnpm
andyarn
are always installed.In my testing, this makes the suite run a couple of minutes faster on average.